Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more! 9 years of continuous development and counting.
[x] yarn testjest tests pass with new tests, if relevant
[x] yarn linteslint checks pass with new code, if relevant
[x] yarn format:checkprettier checks pass with new code, if relevant
[x] README.md (or relevant documentation) has been updated with your changes
[x] If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).
Describe your PR
In Ignite X, the model generator would create files that did not pass Prettier config. See "before" screenshot, which came from npx ignite-cli generate model Pizza in a fresh Ignite X app.
This change primarily fixes the prettier error, as seen in the "after" screenshot, which I got by running:
# In my local Ignite X repo
node ~/ignite/bin/ignite generate model --update
node ~/ignite/bin/ignite generate model FixedPizza
One workaround is to disable prettier in Jest, which you'll see in cb78066ea24539569e21dcc20fbf9d5b9fe0c09c. We could drop that commit and just take the snapshot changes from 89841942359faa1c434c000a018d04e27d834777. I'm not sure if there's some other workaround or configuration in place that fixes that problem.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
In Ignite X, the model generator would create files that did not pass Prettier config. See "before" screenshot, which came from
npx ignite-cli generate model Pizzain a fresh Ignite X app.This change primarily fixes the prettier error, as seen in the "after" screenshot, which I got by running:
However, when I attempted to update the Jest snapshots, I ran into this issue from Jest: https://github.com/jestjs/jest/issues/14305
One workaround is to disable prettier in Jest, which you'll see in cb78066ea24539569e21dcc20fbf9d5b9fe0c09c. We could drop that commit and just take the snapshot changes from 89841942359faa1c434c000a018d04e27d834777. I'm not sure if there's some other workaround or configuration in place that fixes that problem.
Screenshots (if applicable)