fix(boilerplate): reworks some mst removal decorators - Githubissues

infinitered / ignite

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more! 9 years of continuous development and counting.

MIT License

17.74k stars 1.4k forks source link

fix(boilerplate): reworks some mst removal decorators #2832

Closed frankcalise closed 3 weeks ago

frankcalise commented 3 weeks ago

Please verify the following:

[ ] yarn test jest tests pass with new tests, if relevant
[ ] yarn lint eslint checks pass with new code, if relevant
[ ] yarn format:check prettier checks pass with new code, if relevant
[ ] README.md (or relevant documentation) has been updated with your changes
[ ] If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

Closes #2829
Closes #2828
The reasons this occurred is when some different linting rules were applied (due to conditionals getting longer, prettier update, etc) the previous @mst mark up to remove / adjust syntax lines no longer worked. These changes fix that.

How to Test

Observe failure via npx ignite-cli@10.0.3 new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demo
Checkout this branch
Observe no failure via ignite/bin/ignite new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demo where the first ignite directory is this GitHub project

infinitered-circleci commented 3 weeks ago

:tada: This PR is included in version 10.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: