infinitered / ignite

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more! 9 years of continuous development and counting.
MIT License
17.71k stars 1.4k forks source link

Add a generator for react-native-elements #475

Closed juddey closed 7 years ago

juddey commented 8 years ago

The react-native-elements project has some ui awesomeness that we should grace ignite with.

shroukkhan commented 8 years ago

+1 . it looks awesome!

juddey commented 8 years ago

So the install of this module is a sinch: npm install react-native-elements its pure js.

I'm thinking an --element option or similar passed to component/screen/container would be how it might work in practice. eg:

ignite g container AwesomeContainer --element button list tabs

Would scaffold a container, with button, list and tab elements in the render method.

We should also check if the module is in package.json first, and if not, then install it.

How does that sound for a way forward?

GantMan commented 8 years ago

Eh, maybe not as much of a sinch as it sounds. Or maybe it is, let's see.

So if someone says they want react native elements, the command should be :

ignite add react-native-elements this would:

GantMan commented 8 years ago

if you agree to the experience above, I can then rope in other devs to start describing how this would work. Including the author of RNE.

btw, thanks for keeping me from being lazy 🏃 I've been thinking and not acting on this!

GantMan commented 8 years ago

ALSO: It might be easier to move an in-house generator over first, like Maps. Especially since this would add a command rather then modify one. But then again, if they are based on sub-generators, it might be simple.

juddey commented 8 years ago

I was more meaning that the install of RNE was a sinch, not necessarily implementing it! 😅

check the .ignite file if RNE has been added already under plugins. If it's already been added it would show a friendly message telling you so. add to plugins section of .ignite automatically npm/yarn install node module (as you stated)

This is all good. You've just articulated what I thought it would do here. :mind_read:

For the tricky part, I think its worth doing a quick mockup of how the code might look at the end of the process, and how we might get there in terms of prompts etc. (this might be short, or long, but then at least we're all understanding each other on the end result.) Mocking only needs to be done for the tricky part, the rest has enough explanation.

I'd hardly call it lazy. We all need a life outside our online one 🎈

GantMan commented 8 years ago

good call on the mock! I'll think on it, but if you beat me to it, I won't complain :) I'm packing for a trip to SanFran right now.

This IRL thing is over-rated. Did you know people still wear pants out in the world? Perhaps digital is the right way to go

🚫 👖 💯

juddey commented 8 years ago

@GantMan ➖ 👖 ? 😱 ➕ 🏃 : 👌

I'll have a think on the mock too.

GantMan commented 8 years ago

image

jamonholmgren commented 7 years ago

FYI: https://github.com/dabit3/ignite-elements

Close?

juddey commented 7 years ago

Done.