infinitered / ignite

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more! 9 years of continuous development and counting.
MIT License
17.72k stars 1.4k forks source link

[2.0] Printout after questions is odd #634

Closed GantMan closed 7 years ago

GantMan commented 7 years ago

take a look at this: image

Looks like it asks questions several times, when you go back and look at it. What's up with that?

enquirer lib bug?

skellock commented 7 years ago

I've seen the duplicates on 1 line, but this is the first time I've seen it THAT bad. Hah!

Something is not right.

kevinvangelder commented 7 years ago

This got much worse when I switched the Dev Screens question to be the list type. I meant to mention it in the PR but forgot.

jamonholmgren commented 7 years ago

I've replicated this issue with a barebones prompt-list and enquirer repo and filed an issue.

https://github.com/enquirer/prompt-list/issues/2

EDIT: No I haven't replicated. Continuing to investigate.

EDIT 2: Definitely replicated. Going to hope that they fix this issue. If not, we may need to change to Inquirer instead.

Current status: Blocked by prompt-list issue 2.

jamonholmgren commented 7 years ago

I just tested using Inquirer instead of Enquirer and it works fine. We would lose these prompt types (unless there are plugins for these, which there possibly are -- haven't checked):

radio question autocomplete

For now, I'm going to introduce a dependency on Inquirer into Ignite until prompt-list is fixed and then we can switch back to the Gluegun one. Or if Gluegun switches to Inquirer too.