informalsystems / cosmwasm-to-quint

Semi-automated modelling and Model-Based Testing for CosmWasm contracts
Apache License 2.0
14 stars 1 forks source link

Fix criteria for translating a function to an action #17

Closed bugarela closed 5 months ago

bugarela commented 5 months ago

Hello :octocat:

Closes https://github.com/informalsystems/cosmwasm-to-quint/issues/15

We now only translate functions with DepsMut as actions, while functions with Deps are translated to pure helper definitions.

This doesn't have an impact on any CTF contract (so, in our snapshot tests), but it fixes a problem that both @p-offtermatt and @ivan-gavran hit. I manually checked that this fixes those.

bugarela commented 5 months ago

LGTM. would it be worth it to just add either my or Ivans example to the snapshot tests?

It would be helpful, but your repo is private (and I don't know for how long this one will stay private), and Ivan's is way too big, so I think not worth it for now.