Add character counter on individual status page.

innoq / statuses

statuses

Apache License 2.0

13 stars 14 forks source link

Closed mvitz closed 9 years ago

mvitz commented 9 years ago

Fixes #91.

mvitz commented 9 years ago

Because I'm not that firm in JavaScript (as booth of you saw from my PRs) could you explain to me:

why an additional variable is preferred?
if it's possible that a counter is already in place. Because the charCount binding is only done on page load.

Thank for your patience with me.

FND commented 9 years ago

the additional variable helps readability (clarifies what it is you're selecting there) and helps avoid redundant selector operations (cf. https://github.com/mvitz/statuses/commit/9fa43aca0a97be7eeffbb17d3152c6eb2ea80e04#commitcomment-8523575) - though to be honest, it's mostly because foo($(bar)) makes my eyes bleed

FND commented 9 years ago

I'm not sure about your second question - would have to look into that more thoroughly.

PS: You're doing pretty good, and your contributions are much appreciated.

aheusingfeld commented 9 years ago

PS: You're doing pretty good, and your contributions are much appreciated.

I totally second that! Good job! :)

aheusingfeld commented 9 years ago

Would you mind to rebase, squash your commits and git push -f? Thanks. :)