search

innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

Top app menu on small devices #106

Closed mvitz closed 9 years ago

mvitz commented 9 years ago

At least in Safari the top app menu looks strange when folding into hamburger menu.

I think statuses on the left corner should be visible all the time but doesn't. screen shot 2014-11-15 at 19 40 42

Everything appears right of statuses in hamburger menu. Should be at the bottom. screen shot 2014-11-15 at 19 41 04

stilkov commented 9 years ago

Ouch, must have messed that up somewhere late, I’m quite sure it worked nicely in between. Will investigate, any hints welcome.

mvitz commented 9 years ago

First hint: The statuses link needs to in div.navbar-header bellow the button and not inside the ul element. I applied the fix locally but now the menu bar has two columns. The top one has only the statuses link and the second contains the other links. I investigate why this happens.

mvitz commented 9 years ago

Question: Why do we pass the navigation into the common layout? Because the navigation is fixed we could inline the navigation into the layout (Hint: Then the request must be passed there)?

aheusingfeld commented 9 years ago

The HTML is broken overall at the moment. In https://github.com/innoq/statuses/pull/86#issuecomment-61424314 I suggested to let the menu appear on the left side of the status list. Does anyone disagree with this suggestion?

stilkov commented 9 years ago

I think you meant the right side, didn't you? And I disagree.

aheusingfeld commented 9 years ago

@stilkov no, I mean "left" as in https://github.com/innoq/statuses/pull/86#issuecomment-61424314.

And I disagree.

does that mean you really want it that way??????

screen shot 2014-11-15 at 20 38 49

stilkov commented 9 years ago

Yes. Why not?

aheusingfeld commented 9 years ago

Apart from "Statuses" and "Everything" pointing to the same URL and the icons being too large for the text, it feels aesthetically wrong. It's somehow the opposite of the otherwise clean, whitespace honoring layout - at least in my eyes. Do we really need all the options up there?

mvitz commented 9 years ago

Maybe we should discuss this in a new issue? This one was just intended to fix the issue regarding the top menu.

stilkov commented 9 years ago

I think we agree what the goal is. I'm trying to find the least obtrusive way to place these options without cluttering up stuff. The top bar was there anyway, so I could move stuff to it and do away with the big box on the right side. But I'm completely open to alternative suggestions.=