Remove unused ressources.

innoq / statuses

statuses

Apache License 2.0

13 stars 14 forks source link

Remove unused ressources. #109

Closed mvitz closed 9 years ago

mvitz commented 9 years ago

Fixes #93.

Remove following ressources:

jQuery (outdated version 1.8.3 and already provided by CDN)
Bootstrap (outdated version 2.0.2 and already provided by CDN)
jQuery-charCount (css not used, min.js is broken)

aheusingfeld commented 9 years ago

I'd recommend to keep the public/statuses/lib/jquery-charCount.css otherwise we only have the modified version without any comments!

mvitz commented 9 years ago

I also though about this but you can get the css file from history if needed. I also found out that the jQuery-charCount library is no longer available from the web. Maybe we should use our own version or a plugin which is maintained?

aheusingfeld commented 9 years ago

jQuery-charCount (css not used, min.js is broken)

We modified this version to play well with Bootstrap 3 - unfortunately we couldn't push the changes upstream as there is no upstream project anymore. Therefore it is our version now.

What do you mean by "min.js is broken"?

mvitz commented 9 years ago

Ok didn't know this. I mean the minified version does not match the non-minified version. E.g. the function charCount takes only one argument in the minified version instead of two. It generates other elements (div instead of span) and uses other classes (badges). Maybe this is the case because the minified version matches the original charCount library and the non-minified version is patched by us.

aheusingfeld commented 9 years ago

Maybe this is the case because the minified version matches the original charCount library and the non-minified version is patched by us.

That's exactly the case. I didn't take the effort to minify the JS and we don't have a pipeline for that. Mea culpa.