Lint warnings

[mvitz]

I executed https://github.com/jonase/eastwood as leininigen lint plugin which leads to the following warnings:

~/Development/innoq/statuses$ lein lint
== Eastwood 0.1.5 Clojure 1.6.0 JVM 1.8.0_25
== Linting statuses.configuration ==
== Linting statuses.backend.time ==
== Linting statuses.backend.json ==
== Linting statuses.backend.core ==
{:file "statuses/backend/core.clj",
 :line 115,
 :column 7,
 :linter :misplaced-docstrings,
 :msg "Possibly misplaced docstring, add-testdata",
 :uri-or-file-name "src/statuses/backend/core.clj"}

{:file "statuses/backend/core.clj",
 :line 115,
 :column 1,
 :linter :unused-ret-vals,
 :msg
 "Constant value is discarded: \"Create a DB with a set of n test updates\"",
 :uri-or-file-name "src/statuses/backend/core.clj"}

== Linting statuses.backend.persistence ==
== Linting statuses.views.common ==
== Linting statuses.views.atom ==
== Linting statuses.views.main ==
== Linting statuses.routing ==
{:file "statuses/routing.clj",
 :line 15,
 :column 10,
 :linter :unlimited-use,
 :msg "Unlimited use of ([statuses.views.main]) in statuses.routing",
 :uri-or-file-name "src/statuses/routing.clj"}

== Linting statuses.server ==
{:file "statuses/server.clj",
 :line 15,
 :column 7,
 :linter :deprecations,
 :msg
 "Var '#'ring.middleware.file-info/wrap-file-info' is deprecated.",
 :uri-or-file-name "src/statuses/server.clj"}

{:file "statuses/server.clj",
 :line 5,
 :column 10,
 :linter :unlimited-use,
 :msg
 "Unlimited use of ([compojure.core] [ring.middleware file file-info stacktrace reload params]) in statuses.server",
 :uri-or-file-name "src/statuses/server.clj"}

== Linting linkification ==
{:file "linkification.clj",
 :line 5,
 :column 24,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

{:file "linkification.clj",
 :line 8,
 :column 23,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

{:file "linkification.clj",
 :line 19,
 :column 27,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

{:file "linkification.clj",
 :line 30,
 :column 48,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

{:file "linkification.clj",
 :line 41,
 :column 34,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

{:file "linkification.clj",
 :line 46,
 :column 27,
 :linter :suspicious-test,
 :msg
 "Found constant form with class clojure.lang.PersistentVector inside deftest.  Did you intend to compare its value to something else inside of an 'is' expresssion?",
 :uri-or-file-name "test/linkification.clj"}

== Warnings: 11 (not including reflection warnings)  Exceptions thrown: 0
Subprocess failed

If interested I open a PR with added plugin and fixed warnings.

[stilkov]

If interested I open a PR with added plugin and fixed warnings.

Please do.