search

innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

Add link to github for commit hash on info page. #156

Closed mvitz closed 9 years ago

mvitz commented 9 years ago

Fixes #137.

aheusingfeld commented 9 years ago

Fixes #137.

...is not a sufficient commit message IMHO. When you browse through your local repo you wouldn't want to open a link to Github for each commit just to get it's detailed intention and changes.

mvitz commented 9 years ago

The commit message is:

Add link to github for Commit hash on info page.
Fixes #137.

as you can see here: https://github.com/mvitz/statuses/commit/2e150d36d9c22208f15f16f306e1d53c3aa2a589

The part you quoted is only the comment of the pull request (which GitHub inserts automatically when creating a PR).

aheusingfeld commented 9 years ago

https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines

mvitz commented 9 years ago

Next try. Rebased PR into separate commits and added more meaningful commit message bodies.