search

innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

closing parenthesis erroneously included in hashtag #177

Open FND opened 9 years ago

FND commented 9 years ago

posting "lorem (ipsum #foo)" results in <a href=".../updates?query=%23foo%29">foo)</a> - surely that's almost always not what the user intended?

mvitz commented 9 years ago

Thanks for reporting this (and sorry for answering that late).

Currently a tag (which is linked to when using the #) is defined as any character till the next whitespace occurrence. If we agree to change this we should discuss which characters to exclude because I think there would be many more candidates to exclude.

FND commented 9 years ago

we should discuss which characters to exclude because I think there would be many more candidates to exclude

YAGNI? Users have a tendency to be hard to predict, so I'd rather fix bugs as they come up in real usage.

Having said that, I suppose punctuation ([.,!?:;"']) should be safe - though only if followed by whitespace (think "#foo:bar").

sorry for answering that late

How dare you take the weekend off!