search

innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

show links to images as inline #47

Closed phaus closed 9 years ago

phaus commented 11 years ago

If a Links ends with an extension (or pro version: has ContentType of an Image), it would be great to show that Images as Inline in a Post.

stilkov commented 11 years ago

Sorry for the late reaction. I'm not sure about this one. How would we do this? Issue HEAD requests to every linked resource and look for image content types? We'd have to cache the result to avoid doing this over and over again. It's a neat idea, but I'm slightly worried about the added complexity (with small benefit).

stilkov commented 11 years ago

Thinking about this some more, I was wrong and there is no need for caching: We can do the HEAD thing once and just put the img tag into the content. The user’s browser will then retrieve it, obviously no need to do that on the server side. Even simpler, we could allow using img tags in content.

aheusingfeld commented 9 years ago

I unfortunately introduced a duplicate to this with #70. Sorry.

aheusingfeld commented 9 years ago

Done with https://github.com/aheusingfeld/statuses/commit/dfc30de7edbd7d8648313af4dcfc0cfe987476cf