search

innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

Change image preview to opt-in and write the property into the localStorage #79

Closed aheusingfeld closed 9 years ago

aheusingfeld commented 9 years ago

@phl requested: Image preview should require opt-in to not scare away users. The config/ property should be written to localStorage.

stilkov commented 9 years ago

Why local and not server-side storage? Do we want to see these on some devices and not on other? I would have guessed it’s more of a matter of personal taste in general.

aheusingfeld commented 9 years ago

Why local and not server-side storage?

well, because I wanted to experiment with localStorage?! ;) No, seriously: Yes, I'd like to have images on the desktop and no images on my iPhone when I'm roaming. Does that make sense?

stilkov commented 9 years ago

OK, go ahead and give it a shot if you like.

mvitz commented 9 years ago

I started this in https://github.com/mvitz/statuses/commit/9fa43aca0a97be7eeffbb17d3152c6eb2ea80e04 feedback desired.

Would like to include the Option in template (without JavaScript) but I need more time to figure out how to change this in the template because the structure is fixed to only support links right now.