innoq / statuses

statuses
Apache License 2.0
13 stars 14 forks source link

proposal to fix #74: add reply button #85

Closed aheusingfeld closed 9 years ago

aheusingfeld commented 9 years ago

NOTE: I'm not sure if this is actually the best solution. I thought of two other variants

  1. make it completely "unobtrusive" and not only add the click listener via JS but also the button
  2. add the form directly and only control visibility via JS

Comments very welcome.

Here is a screenshot of the current implementation: screen shot 2014-10-29 at 00 52 19

FND commented 9 years ago

As long as there's a link and the respective resource is merely embedded via JavaScript, that should be fine. IIRC that's the way it currently works (though there seems to be a fair amount of DOM awareness in the code), and AFAICT you haven't changed that basic approach.

aheusingfeld commented 9 years ago

@FND fixed your remarks. Ready to merge IMHO

FND commented 9 years ago

LGTM

(though I've been sitting at a dreary airport for 4+ hours now, so YMMV)