Closed aheusingfeld closed 9 years ago
As long as there's a link and the respective resource is merely embedded via JavaScript, that should be fine. IIRC that's the way it currently works (though there seems to be a fair amount of DOM awareness in the code), and AFAICT you haven't changed that basic approach.
@FND fixed your remarks. Ready to merge IMHO
LGTM
(though I've been sitting at a dreary airport for 4+ hours now, so YMMV)
NOTE: I'm not sure if this is actually the best solution. I thought of two other variants
Comments very welcome.
Here is a screenshot of the current implementation:![screen shot 2014-10-29 at 00 52 19](https://cloud.githubusercontent.com/assets/534272/4819162/f111feca-5efd-11e4-867e-fd1250239cd9.PNG)