search

innovationOUtside / nbev3devsim

Ev3DevSim ipywidget in Jupyter notebooks
Apache License 2.0
5 stars 0 forks source link

Small robot borked... #121

Closed psychemedia closed 3 years ago

psychemedia commented 3 years ago

If the small robot profile is selected, the noise model doesn't seem to be applied?

psychemedia commented 3 years ago

Okay, so it seems that we have some fixed dimensions being used to set something...

eg https://github.com/innovationOUtside/nbev3devsim/blob/bbe119e388b474ffa79f698de0fdef1007037c99/nbev3devsim/js/EV3devSim.js#L542

eg

const WHEEL_WIDTH = 20; 
const SENSOR_WIDTH = 30;
const SENSOR_DIAMETER = 20;

So these need calculating relative to robots actual dimensions? Or are these dimensions purely related to the drawing?

(There may be other issues / inconsistencies?)

psychemedia commented 3 years ago

So.. the events in the noise sliders fire to update values, but these don't seem to attach the the actual robot state. Have we disconnected the the object the the slider events are supposed to update somehow?

Hmmm.. the settings for sensorNoise and wheelNoise are part of robot spec not robot state?