inst-support-eng / panda-pto

Panda-PTO is a in house solution to HR staffing needs
3 stars 0 forks source link

Soft Delete Users #145

Closed Steaphan-Sadler closed 5 years ago

Steaphan-Sadler commented 5 years ago

Note: this issue includes the deletion of PTO requests, and changes may be needed with addition of soft-deleting PTO requests.

Test Plan User includes is_deleted status

  1. In rails console, find a user 2.Ensure is_deleted status is included issue #129

is_deleted status on import deletes future requests

  1. Add a future request and a past request to a seeded user, keeping the user's page open
  2. Re-import the seeded user, include the 'is_deleted' column. Set user to true
  3. Refresh user's page, noting that future requests are deleted issue #130

is_deleted should hide user in admin UI

  1. After re-importing user, note that user's name does not appear on admin page issue #131
Steaphan-Sadler commented 5 years ago

Additional Commit to change password of Users when deleted, prevent users from logging in.

merchang commented 5 years ago

when viewing a deleted user page, we should see:

Steaphan-Sadler commented 5 years ago

Commit 7 meets additional considerations for Deleted users: