Request improvements - Githubissues

merchang commented 5 years ago

verify requests are soft deleted

[x] delete a from the side bar on the calendar page
[x] verify the request no longer appears in the UI: 1. the sidebar 2. user#show 3. user#edit
[x] verify the user was refunded appropriately
[x] verify the users information was removed successfully from the related calendar object (signed_up_total, signed_up_agents[])
[x] locate the request in console, verify is_deleted => true

verify recalculation

[x] create a new request for user A
- this request should for a calendar day that is on the cusp of a price increase, i.e. this request will move the pushes the day to a higher per hour price. (update the base_value of an item and manually run UpdatePrice.update_calendar_item() in console if needed)
[x] create a new request for user B on the same day
[x] delete the request for user A in the UI
[x] verify user b's request price went down appropriately
[x] verify user b's bank value was refunded appropriately

odds and ends

[x] verify deleted requests appear in request export csv (for all users and individuals)
[x] verify requests soft delete and refund when deleting as an admin/sup

fixes #138 fixes #139 fixes #155

Steaphan-Sadler commented 5 years ago

Deleting request via sidebar still destroys it, cannot be found through console, when the user deletes their own request. (intended, yes?)

When request is deleted by Admin, 100% is_deleted => true

Steaphan-Sadler commented 5 years ago

inst-support-eng / panda-pto