search

inst-support-eng / panda-pto

Panda-PTO is a in house solution to HR staffing needs
3 stars 0 forks source link

Message CSV 'Status' column only returns success #202

Closed BlinkVonDoom closed 4 years ago

BlinkVonDoom commented 4 years ago

Description

When creating a new message status column only returns as 'success' regardless of outcome

Steps To Reproduce

  1. Go to admin/bat_signal
  2. Create a message that will fail
  3. In console search for Message.last
  4. Notice objects status key will return success

Expected behavior

Failed messages should have the appropriate status

Additional information

https://github.com/inst-support-eng/panda-pto/blob/b8d76c4b886e7229b087cd7011b1afb380b4180c/app/controllers/messages_controller.rb#L42

Needs better handling, res currently returns 1 or 0, and should check for this.

BlinkVonDoom commented 4 years ago

closed with https://github.com/inst-support-eng/panda-pto/commit/0f91d706723efa059c63b9693cdc453c1513ec02