search

inst-support-eng / panda-pto

Panda-PTO is a in house solution to HR staffing needs
3 stars 0 forks source link

Create handling around users without schedules / start_time || end_time #203

Closed BlinkVonDoom closed 4 years ago

BlinkVonDoom commented 4 years ago

Description

/models/users.rb will currently stop execution for syncing users from Humanity if they do not have a start_time or end_time when syncing.

Steps To Reproduce

Steps to reproduce the behavior:

  1. run rake sync_humanity_users
  2. A user object without start_time || end_time will stop rake

Expected behavior

Users without start_time || end_time should be skipped and not have the sync stop running.

Additional information

api returns "value": "" for users without start_time / end_time, we are currently looking for nil https://github.com/inst-support-eng/panda-pto/blob/9887a34e335a86421a1bc4d9daf911528fcd7e56/app/models/user.rb#L123