move check of camera TTL from state-machine to initialization

int-brain-lab / iblrig

Main repository for IBL rig code

https://int-brain-lab.github.io/iblrig/

MIT License

22 stars 21 forks source link

move check of camera TTL from state-machine to initialization #558

Open bimac opened 11 months ago

bimac commented 11 months ago

currently, when starting a session inheriting from ActiveChoiceWorldSession, the task blocks up if no sync pulses from the camera are received on the Bpod's behavior port during the first state of the state-machine:

https://github.com/int-brain-lab/iblrig/blob/3d16f407397f9ab9342746fe95d0b4a71a5d0212/iblrig/base_choice_world.py#L578-L585

could/should this state have a time-out or be entirely optional?

[ ] adapt state-machine (separate branch)
[ ] extractors

bimac commented 11 months ago

@oliche @samupicard

bimac commented 11 months ago

also, from a design-perspective - does it make sense to do this in the state-machine at all?

samupicard commented 9 months ago

I don't know about the design question, but the camera-dependency definitely needs to be parametrized. A buggy video PC can currently block up the entire task pipeline, and there is no workaround