search

intel / libvpl

Intel® Video Processing Library (Intel® VPL) API, dispatcher, and examples
https://intel.github.io/libvpl/
MIT License
262 stars 80 forks source link

Add ARM aarch64 support to dispatcher #1

Closed wd13384 closed 1 year ago

wd13384 commented 3 years ago

Signed-off-by: William Dean wd13384@gmail.com

Tested on Apple M1 with oneVPL provided docker files (except Ubuntu 19.10, which does not appear to support aarch64 in docker hub)

mav-intel commented 3 years ago

Thanks for the update! After some internal discussions we think the better direction is to remove the specific architectures completely and just check what we care about directly - the bit-ness.

So rather than checking for i386, perhaps something like?

#if INTPTR_MAX == INT32_MAX
    #define LIBMFXSW "libvplswref32.so.1"
    #define LIBMFXHW "libmfxhw32.so.1"
#elif INTPTR_MAX == INT64_MAX
    #define LIBMFXSW "libvplswref64.so.1"
    #define LIBMFXHW "libmfxhw64.so.1"
#else   
    #error Unsupported architecture  
#endif
StefanBruens commented 1 year ago

@wd13384 - can you please rebase this? @mav-intel - is there anything in here which is still unresolved and needs changing?

This not only fixes aarch64, but also RISC-V, and all the legacy archs out there.

StefanBruens commented 1 year ago

There is also another x86_64 check here, which is AFAICS completely unnecessary: https://github.com/oneapi-src/oneVPL/blob/15b79165c30fc4a7bf6efdf261a39b128b63b896/tools/legacy/sample_common/src/sample_utils.cpp#L45-L49

jonrecker commented 1 year ago

PR was out of sync with the HEAD so changes were pulled into the following commit: https://github.com/oneapi-src/oneVPL/commit/6182082a12a4fc90b3db89568b3924f2c88f2704