intel / libvpl

Intel® Video Processing Library (Intel® VPL) API, dispatcher, and examples
https://intel.github.io/libvpl/
MIT License
262 stars 80 forks source link

[regression][configure] commit 33ac97cd cause build problem #57

Closed Bin-CI closed 1 year ago

Bin-CI commented 2 years ago

we build this repo without wayland support and without BUILD_TOOLS=OFF before But now we need to add BUILD_TOOLS=OFF for the build, so it is the configure problem

User Specified Option Requirements Met (e.g. deps)? Feature Result Configure Result
BUILD_TOOLS=OFF Yes Disabled Success
BUILD_TOOLS=OFF No Disabled Success
BUILD_TOOLS=ON Yes Enabled Success
BUILD_TOOLS=ON No Error Error
Unspecified Yes Enabled Success
Unspecified No Disabled Success

The table (above) are the expected results. But the last use-case does not work.
The user should not be forced to disable an optional feature because they don’t have or want its dependencies installed.
The configure should automatically turn on/off optional features if the user does not specify it explicitly.
The only time configure should error is if the user explicitly enables an optional feature but has not satisfied the requirements (e.g. dependencies).

regression commit: https://github.com/oneapi-src/oneVPL/commit/33ac97cd913d1c5068a034c6b97223f4df2d8bc9

xuguangxin commented 2 years ago

@Bin-CI , maybe providing a configuration comandline and output is helpful

Bin-CI commented 2 years ago
cmake -DCMAKE_INSTALL_PREFIX="/opt/media/install" -DCMAKE_INSTALL_LIBDIR="/opt/media/install/lib"

error log:

22:36:58,732 INFO  - -- Checking for module 'wayland-protocols>=1.15'
22:36:58,736 INFO  - --   No package 'wayland-protocols' found
22:36:58,736 INFO  - CMake Error at tools/legacy/sample_common/CMakeLists.txt:115 (message):
22:36:58,736 INFO  -   wayland-protocols not found: set BUILD_TOOLS=OFF to skip building tools
22:36:58,736 INFO  -
22:36:58,736 INFO  -
22:36:58,736 INFO  - CMake Error at tools/legacy/sample_common/CMakeLists.txt:155 (message):
22:36:58,736 INFO  -   xcb not found: set BUILD_TOOLS=OFF to skip building tools
22:36:58,736 INFO  -
22:36:58,736 INFO  -
22:36:58,748 INFO  - -- Checking for module 'libdrm>=2.4.91'
22:36:58,766 INFO  - --   Found libdrm, version 2.4.105
22:36:58,814 INFO  - CMake Error at tools/legacy/sample_misc/wayland/CMakeLists.txt:62 (message):
22:36:58,814 INFO  -   Wayland modules not found: set BUILD_TOOLS=OFF to skip building tools
mav-intel commented 2 years ago

@Bin-CI Are you asking for an explicit waylaid enable/disable configuration for tools? Do you want the same for X11?

Bin-CI commented 2 years ago

like the configure table :
as build option without any configure, so the default behavior should be execute without any block
you can dump the configure result like wayland-protocols not found without build tools,
not told user need add build option to finish the configure step

tletnes commented 1 year ago

fixed in f2aba7f5f06f66fe42d471415c4e3928abb4c602