intel / libvpl

Intel® Video Processing Library (Intel® VPL) API, dispatcher, and examples
https://intel.github.io/libvpl/
MIT License
262 stars 80 forks source link

Move libva headers behind the LIBVA_SUPPORT ifdef #62

Closed michalkielan closed 1 year ago

michalkielan commented 1 year ago

I have observed the compilation error when building onevpl on virtual machine without the libva installed even if the VA is disabled in cmake config. Most likely all of the va/* headers should be behind the ifdef.

-- Build:
--   BUILD_DISPATCHER_ONLY                : OFF
--   BUILD_DEV                            : ON
--   BUILD_DISPATCHER                     : ON
--   BUILD_TOOLS                          : ON
--   ENABLE_VA                            : OFF
--   ENABLE_DRM                           : OFF
--   ENABLE_WAYLAND                       : OFF
--   ENABLE_X11                           : OFF
--   ENABLE_DRI3                          : OFF
--   BUILD_SHARED_LIBS                    : ON
--   BUILD_TESTS                          : OFF
--   BUILD_EXAMPLES                       : OFF
--   BUILD_PREVIEW                        : ON
--   BUILD_PYTHON_BINDING                 : ON
--   BUILD_DISPATCHER_ONEVPL_EXPERIMENTAL : ON
--   BUILD_TOOLS_ONEVPL_EXPERIMENTAL      : ON
--   INSTALL_EXAMPLE_CODE                 : ON
-- Configuring done
-- Generating done
-- Build files have been written to: /home/runner/work/onevpl/build
[1/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/vpl/mfx_dispatcher_vpl.cpp.o
[2/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/linux/mfxloader.cpp.o
[3/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/vpl/mfx_dispatcher_vpl_loader.cpp.o
[4/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/vpl/mfx_dispatcher_vpl_log.cpp.o
[5/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/vpl/mfx_dispatcher_vpl_lowlatency.cpp.o
[6/93] Building CXX object dispatcher/CMakeFiles/VPL.dir/vpl/mfx_dispatcher_vpl_msdk.cpp.o
[7/93] Building CXX object tools/cli/CMakeFiles/vpl-inspect.dir/vpl-inspect.cpp.o
[8/93] Building CXX object tools/cli/system_analyzer/CMakeFiles/system_analyzer.dir/system_analyzer.cpp.o
FAILED: tools/cli/system_analyzer/CMakeFiles/system_analyzer.dir/system_analyzer.cpp.o 
/usr/bin/c++ -DONEVPL_EXPERIMENTAL -D_FORTIFY_SOURCE=2 -I/home/runner/work/onevpl/api -z relro -z now -z noexecstack  -O3 -DNDEBUG -fPIE -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong -Wall -MD -MT tools/cli/system_analyzer/CMakeFiles/system_analyzer.dir/system_analyzer.cpp.o -MF tools/cli/system_analyzer/CMakeFiles/system_analyzer.dir/system_analyzer.cpp.o.d -o tools/cli/system_analyzer/CMakeFiles/system_analyzer.dir/system_analyzer.cpp.o -c /home/runner/work/onevpl/tools/cli/system_analyzer/system_analyzer.cpp
/home/runner/work/onevpl/tools/cli/system_analyzer/system_analyzer.cpp:22:14: fatal error: va/va.h: No such file or directory
   22 |     #include "va/va.h"
      |              ^~~~~~~~~
compilation terminated.
SupreetSinghPalne commented 1 year ago

Hi @michalkielan , this issue is fixed and merged. Commit link - 5b797a1