search

intel / libvpl

Intel® Video Processing Library (Intel® VPL) API, dispatcher, and examples
https://intel.github.io/libvpl/
MIT License
262 stars 80 forks source link

[legacy-vpp] Support output with MFX_FOURCC_BGR4 format. #71

Closed Austin-Hu closed 1 year ago

Austin-Hu commented 1 year ago

Also fixed the issue that redundant pixel(s) would be written to output file, when the input surface isn't aligned with width or height.

Signed-off-by: Austin Hu austin.hu@intel.com

Austin-Hu commented 1 year ago

Hi @akwrobel, please help review this PR once you'd be available. Thanks!

jeffreymcallister commented 1 year ago

Sorry for the delayed reply. We have reviewed your fix and it works. After the change there is no example which uses bgr4 color format, so the code would not be regularly tested. However, it is a good reference for how to work with yet another format and we want to start showing more options.

One request before merging: each example has a util.h file. We want to keep util.h identical for every example. Would you prefer to copy your updated util.h to the other examples and update the PR, or would you rather that we do it?

Austin-Hu commented 1 year ago

@jeffreymcallister, the same with PR #67, please help make the change to other util.h files. Thanks!

SupreetSinghPalne commented 1 year ago

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Austin-Hu commented 1 year ago

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

SupreetSinghPalne commented 1 year ago

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

Oh my bad here is the link - 5f310e9

Austin-Hu commented 1 year ago

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

Oh my bad here is the link - 5f310e9

Thanks, and it LGTM. Let me close this one.