Open eero-t opened 1 year ago
Pre-condition:
sudo apt install shellcheck
dnf install shellcheck
There are quite a few shell scripts:
find -name '*.*sh' | wc -l 38
And they trigger a lot of shellcheck warnings:
shellcheck
find -name '*.*sh' | xargs shellcheck | grep SC[0-9]*: | wc -l 658
Note: one should not follow shellcheck recommendations blindly. Main one where one could screw up is changing this:
base_opts="-a -b -c" command $base_opts -d -e -f
To:
base_opts="-a -b -c" command "$base_opts" -d -e -f
My preferred way is just adding shellcheck override for them, or switching to helper function like this:
run_command () { command -a -b -c $* } run_command -d -e -f
Whichever makes more sense for given code.
@dvrogozh any comments on this?
This issue is where help is clearly wanted. This task is in a backlog, but I can't say when we will have a chance to look into it ourselves.
Pre-condition:
sudo apt install shellcheck
ordnf install shellcheck
There are quite a few shell scripts:
And they trigger a lot of
shellcheck
warnings:Note: one should not follow
shellcheck
recommendations blindly. Main one where one could screw up is changing this:To:
My preferred way is just adding shellcheck override for them, or switching to helper function like this:
Whichever makes more sense for given code.