intel / scikit-learn-intelex

Intel(R) Extension for Scikit-learn is a seamless way to speed up your Scikit-learn application
https://intel.github.io/scikit-learn-intelex/
Apache License 2.0
1.23k stars 175 forks source link

Memory leak in LogisticRegression #556

Closed Alexsandruss closed 3 years ago

Alexsandruss commented 3 years ago

Describe the bug Memory leak in daal4py.sklearn.linear_model._logistic_path_0_22.LogisticRegression was appeared in according tests in PR https://github.com/IntelPython/daal4py/pull/553. CI link: https://github.com/IntelPython/daal4py/runs/2085105525

To Reproduce Steps to reproduce the behavior:

  1. Remove 'LogisticRegression' from BANNED_ESTIMATORS in daal4py/sklearn/test/test_memory_usage.py
  2. Run test

Expected behavior Absence of memory leak

Output

   AssertionError: Size of extra allocated memory is greater than 25% of input data:
        Input data size: 816000 bytes
        Extra allocated memory size: 7632826 bytes / 935.4 %
   assert 7632826 < (0.25 * 816000)

Environment:

OnlyDeniko commented 3 years ago

https://github.com/scikit-learn/scikit-learn/issues/20061