search

intel / scikit-learn-intelex

Intel(R) Extension for Scikit-learn is a seamless way to speed up your Scikit-learn application
https://intel.github.io/scikit-learn-intelex/
Apache License 2.0
1.23k stars 175 forks source link

Segmentation fault while getTreeState applied to the model converted from lightgbm #663

Closed cmsxbc closed 3 years ago

cmsxbc commented 3 years ago

Describe the bug As title.

To Reproduce Steps to reproduce the behavior:

  1. use example model from lightgbm lightgbm simple_example
  2. convert the model and apply to getTreeState 
    d4p_model = daal4py.get_gbt_model_from_lightgbm(gbm)
daal4py.getTreeState(d4p_model, 0)
  3. crash here.

Expected behavior No segfault or raise Exception if it's not a valid operation.

Output/Screenshots

image

Environment:

ShvetsKS commented 3 years ago

@cmsxbc thanks a lot for reporting the bug. Fix for cpp kernel was prepared in PR: https://github.com/oneapi-src/oneDAL/pull/1634

ShvetsKS commented 3 years ago

@cmsxbc Please check the fix. PR#1634 was merged

cmsxbc commented 3 years ago

@ShvetsKS It works. Thanks a lot.