interledgerjs / five-bells-integration-test

A module to help with testing Five Bells components against each other
Other
2 stars 3 forks source link

New crypto-conditions #17

Closed justmoon closed 8 years ago

justmoon commented 8 years ago

This migrates Five Bells to the new crypto-conditions format. See https://github.com/interledger/five-bells-condition

Requires interledger/five-bells-ledger#233, interledger/five-bells-connector#146, interledger/five-bells-notary#57, interledger/five-bells-sender#63 and a new module interledger/five-bells-receiver.

justmoon commented 8 years ago

Should explain the addition of the one-to-one backend in the connector: While working on the plane I noticed that the integration tests actually call out to fixer.io. Since tests shouldn't depend on any outside services, I created the one-to-one backend as a simpler backend for testing.

I could have also mocked the fixer.io endpoint - but I figured a 1:1 backend would be useful anyways and the fixer.io stuff isn't something we're actually planning to use in production, so doesn't make too much sense to exercise it in the tests.

clark800 commented 8 years ago

LGTM