interledgerjs / five-bells-integration-test

A module to help with testing Five Bells components against each other
Other
2 stars 3 forks source link

feat: tests in line with route-broadcast/quoting changes #59

Closed momerath42 closed 7 years ago

momerath42 commented 7 years ago

With the changes to quoting, to support improved-route-broadcast, some test values changed in the ten-thousandths place. @sentientwaffle speculated that this was due to a "difference between rounding at each hop of the quote vs shifting the curve by the scale"

The unknown ledgers test fails because the quoting code doesn't return its locally-constructed quote when it fails to get a remote one, and it fails in this case with "This connector does not support the given asset pair", which I believe is the expected behavior of the test setup. Suggestions welcome as to how to rewrite this test, or its usefulness given the rest of the tests.