Companion of https://github.com/interledgerjs/ilp-kit/pull/398

interledgerjs / five-bells-integration-test

A module to help with testing Five Bells components against each other

Other

2 stars 3 forks source link

Companion of https://github.com/interledgerjs/ilp-kit/pull/398 #77

Closed michielbdejong closed 7 years ago

sentientwaffle commented 7 years ago

Does running all of the tests against both modes add anything? I think it would be simpler if all the tests were run in one mode, then maybe a single relevant test in the other mode to make sure it works.

michielbdejong commented 7 years ago

IIRC the ilp-kit tests are really quite minimal: get a quote, send a payment. But I'll see if there are things that don't make sense to test in both modes of operation.

michielbdejong commented 7 years ago

I could make running the user tests optional so that they are only run on the network with curves, but I think the overhead of running them on both networks is minimal.

@sharafian what do you think? This review request is only about the second commit in this PR, not the first one.

sentientwaffle commented 7 years ago

dj-ilqp passes without https://github.com/interledgerjs/five-bells-integration-test/pull/77/commits/bc8467183df24d1c5fb41b0cc5fb571b08be4c49, what changed?

michielbdejong commented 7 years ago

not sure, but I think since it's now getting the quote from the curve, it apparently gets a slightly different value than when it does a live quote. Will investigate further where the exact difference is coming from, might be exposing a deeper bug where quote responses don't obey curves.

michielbdejong commented 7 years ago

nothing left to merge here, closing.