search

interledgerjs / five-bells-integration-test

A module to help with testing Five Bells components against each other
Other
2 stars 3 forks source link

ILP kit v4 does not run on node v7 #90

Closed dappelt closed 6 years ago

dappelt commented 6 years ago

Trying to run ILP kit v4 on node v7 results in a compilation error (to be more precise, the code in ./client does not compile). In consequence, the integration tests are failing:

ilp-kit[Wallet1] Failed to compile.
ilp-kit[Wallet1] ./src/containers/App/App.js
ilp-kit[Wallet1] Module build failed: TypeError: Cannot read property 'type' of undefined
ilp-kit[Wallet1]     at Array.some (native)
ilp-kit[Wallet1]     at Array.forEach (native)

Changing node to v8 solves the problem for the ILP kit tests, but apparently, with node v8 some tests involving SQLite are failing. To avoid integration tests failing, ILP kit's integration tests are disabled. Once @sentientwaffle is done with adapting the integration tests to ILPv4 and makes them node v8 compatible, we should reenable ILP kit's integration tests.

michielbdejong commented 6 years ago

apparently, with node v8 some tests involving SQLite are failing.

@dappelt What is the error? Is there an upstream issue at SQLite about this?

dappelt commented 6 years ago

As discussed during the team meeting, @justmoon mentioned that the version of SQLite we are using has some issues with node v8. Maybe he can provide details.

michielbdejong commented 6 years ago

Triggered https://circleci.com/gh/interledgerjs/ilp-kit/2413 to check if the integration tests are really currently failing in master.

michielbdejong commented 6 years ago

https://circleci.com/gh/interledgerjs/ilp-kit/2412 seems to successfully run with node 8?

dappelt commented 6 years ago

Triggered https://circleci.com/gh/interledgerjs/ilp-kit/2413 to check if the integration tests are really currently failing in master.

It failed. Convinced now? ;-)

https://circleci.com/gh/interledgerjs/ilp-kit/2412 seems to successfully run with node 8?

This test run executed only ILP kit's integration test suite. So it demonstrates that ILP kit works with node v8. The problem is that we cannot upgrade all CI projects to node v8, due to the aforementioned incompatibility with SQLite.

Anyway, the tests should only be suspended temporarily. @justmoon said the dependency on SQLite will soon be removed. Then we can upgrade all repos to node v8.

michielbdejong commented 6 years ago

I couldn't reproduce your "Failed to compile" error on circleci, but it did fail because of https://github.com/interledgerjs/ilp-kit/issues/486 this time. Anyway, we can revisit both these issues, as well as the sqlite issue, when we reenable the tests.

dappelt commented 6 years ago

I couldn't reproduce your "Failed to compile" error on circleci,

Look closely through the log output of the build you triggered and you will see it. It's a bit hard to spot.

it did fail because of interledgerjs/ilp-kit#486 this time

That issue does not let the integration tests fail, but it is still annoying and should be fixed.

justmoon commented 6 years ago

Closed, ILP Kit no longer used in integration tests.