broke semistandard with ONE :poop:-ING SPACE

intuit / judo

Judo is an easy-to-use Command Line Interface (CLI) Integration Testing Framework, driven from a simple yaml file that also contains assertions.

Other

51 stars 21 forks source link

broke semistandard with ONE :poop:-ING SPACE #28

Closed TennisGazelle closed 4 years ago

TennisGazelle commented 5 years ago

[ ] Does all of your new or changed code have unit tests?
[ ] Is overall unit test statement coverage still above 85%?
[ ] Is code style linting passing with npm run lint?
[ ] Is the related GitHub issue number included in your branch name? ex branch name: fix/12-some-bug
[ ] Is the related GitHub issue number included in your pull request title? example PR title: "12 - Fixes some bug"
[ ] Is documentation still up to date after your change?

TennisGazelle commented 5 years ago

that's what we on DEVGRU find, holes.

approved, but how did this make it past the CircleCI pr build? this shouldn't be possible to get merged into master

worldjoe commented 4 years ago

approved, but how did this make it past the CircleCI pr build? this shouldn't be possible to get merged into master

CircleCI isn't running. I'm going to create an issue for it. Intuit is going to have a "Hacktoberfest" event where they will encourage (with spotlights) engineers to fix issues on our Open Source projects. This one included. So I'll get some new person to contribute that fix and then they'll be in our codebase!