search

intuit / judo

Judo is an easy-to-use Command Line Interface (CLI) Integration Testing Framework, driven from a simple yaml file that also contains assertions.
Other
51 stars 21 forks source link

CircleCI is not running on PR/merge #29

Closed worldjoe closed 4 years ago

worldjoe commented 4 years ago

Is this a bug report, or a feature request? Bug. What is the current behavior? On PRs, CircleCI doesn't run. Oddly it runs for dependabot changes, but not other people's - like https://github.com/intuit/judo/pull/28 If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo repo of the problem. create a PR with a syntax error, note that Circle CI does not complain.

What is the expected behavior? CircleCI should catch compilation errors, linting, etc issues.

KamiKillertO commented 4 years ago

Did you check you circle ci config ? There's one that make circle run builds/workflows for forks

Capture d’écran 2019-09-26 à 17 07 51
ejfrancis commented 4 years ago

@worldjoe it looks I don't have access to the CircleCI job config anymore, can you check this when you've got a chance?

worldjoe commented 4 years ago

Turns out circleci needed to be re-authed to my account.