34: Adding support for JSON files

anands commented 5 years ago

[x] Does all of your new or changed code have unit tests?
[x] Is overall unit test statement coverage still above 85%?
[x] Is code style linting passing with npm run lint?
[x] Is the related GitHub issue number included in your branch name? ex branch name: fix/12-some-bug
[x] Is the related GitHub issue number included in your pull request title? example PR title: "12 - Fixes some bug"
[x] Is documentation still up to date after your change?

At times I have tests in JSON files, adding support for JSON files out of the box would surely be helpful. Changes at the YAML level are not necessary as the js-yaml schema supports JSON in the core schema itself.

ejfrancis commented 5 years ago

Could you please create an accompanying issue that lays out the problem that this is solving, and include that issue number in your branch name? I'm not familiar w/JSON in YAML so any examples would be great. Thanks!

anands commented 5 years ago

@ejfrancis I have created the issue #34 . And the example is already present in the PR: here it is: https://github.com/intuit/judo/pull/33/files#diff-b95cea12fb199522ee6a03ea959033f6

anands commented 5 years ago

@efrancis I have added the example in README

intuit / judo

34: Adding support for JSON files #33