intuit / judo

Judo is an easy-to-use Command Line Interface (CLI) Integration Testing Framework, driven from a simple yaml file that also contains assertions.
Other
51 stars 21 forks source link

Do not append carriage return #75

Open divinity666 opened 3 months ago

divinity666 commented 3 months ago

Thanks a lot for providing this nice tool!

I want to use it to test my own open source project windows executable with it, as it's easy to use and provides everything I need. I just came across the issue, that the tool automatically appends a carriage return to the when calls:

https://github.com/intuit/judo/blob/c1fbbd569fc58652990015340828e7ebde1acf33/src/executor.js#L90

This is unfortunate, as this is depending on operating systems and application expectations.

I would propose to introduce a command line option, which allows to specify the line ending used in when. To keep backward compatibility, this could by default be \r, but should allow to configure nothing or \n or anything else.

What do you think about this?