ioBrokerTranslator / requests

Requests for adapters to be added to weblate.iobroker.net
0 stars 0 forks source link

Add Roborock to Weblate #107

Closed copystring closed 1 year ago

copystring commented 1 year ago

Checklist:

Request:

Please add the following adapter to Weblate: Name: ioBroker.roborock URL: https://github.com/copystring/ioBroker.roborock License: MIT

Remarks: Translations are done in the robot files e.g.: https://github.com/copystring/ioBroker.roborock/blob/main/lib/roborock_vacuum_s4.js I don't think this.states can be translated (yet?)

mcm1957 commented 1 year ago

Translations MUST be done using gulp or adapter dev (npm run translate). All text to be translated MUST be located at i18n file (see first check). It seems that https://github.com/copystring/ioBroker.roborock/blob/main/admin/i18n/en/translations.json currently only contains the inital examples.

Translations in other files cannot be processed by weblate. Translations within other files are discoraged too. I do not think that Admin5 UI (json config) will respect roborock_vacuum.js for translation the gui labels.

Please see documentation: https://github.com/ioBrokerTranslator/doc#request-an-adapter-to-be-added-to-weblate

Please move all translations to the i18n files, commit those changes, perform first two checks again and assign issue to me afterwards.

copystring commented 1 year ago

OK. It seems I did not understood how this works. Translations are for the Admin5 UI only and not for the objects. That's OK. I have corrected my files and pushed an Update to the repo. Let me know if this good now.

copystring commented 1 year ago

Unfortunately I don't have permission to assign the issue back to you.

mcm1957 commented 1 year ago

OK, I'll look pover it this afternoon or tomorrow.

In general it should be possible to manage ANY text as accessing the text stored in the json files from code should be possible. Please ask at telegram how to perform this with minimum effort / best ompatibility.

https://t.me/+gsX-e8k4mLtmZjZk https://t.me/ioBroker_development

mcm1957 commented 1 year ago

The adapter ioBroker.roborock was added to Weblate: https://weblate.iobroker.net/projects/adapters/roborock/

Please add the badge for Weblate translations to your adapter repository: https://github.com/ioBrokerTranslator/doc#add-badge-to-readmemd

From now on, please follow these guidelines: https://github.com/ioBrokerTranslator/doc#maintenance-of-your-adapter