search

iobroker-community-adapters / ioBroker.shelly

Integrate your Shelly devices into ioBroker via MQTT or CoIoT
Other
158 stars 64 forks source link

feature request: Shellyplus2pm: Cover.Open & Cover.Close: Property "duration" not supported yet #681

Closed HGlab01 closed 1 year ago

HGlab01 commented 1 year ago

Shelly device

Shellyplus2pm

Protocol (CoAP / MQTT)

MQTT

The problem

Shellyplus2pm supports like SHSW-25 the Shutter/Cover mode. In this mode for Open and Close an additional property duration can be provided to steer how long the open or close action shall take. This is needed to steer the angel of blinds.

For SHSW-25 duration is provided with the state ..Shutter.Duration For Shellyplus2pm it is not implemented in the adapter yet.

I tested the feature via the API http://IPADDRESS/rpc/Cover.Open?id=0&duration=2 works and executes the open command for 2 seconds.

More info is available at https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/Cover/#coveropen https://shelly-api-docs.shelly.cloud/gen2/ComponentsAndServices/Cover/#coverclose

image

Please provide duration for open and close. This adds a lot of value for steering Shutters. Thanks!

Version of nodejs

not applicable

Version of ioBroker js-controller

n/a

Version of Adapter

6.0.0

Operating system running ioBroker

Linux

Checklist of files to include below

Additional information & file uploads

no log added, as this is a feature request

HGlab01 commented 1 year ago

For SHSW-25 the implementation was done in v3.0.9 based on issue #79 https://github.com/iobroker-community-adapters/ioBroker.shelly/commit/3e8d52160a4e51bd241133d690bd5f8d06459c3a + https://github.com/iobroker-community-adapters/ioBroker.shelly/commit/c6d8274d6df09a7541c9b64286aa154b6b552433

Maybe this helps.

klein0r commented 1 year ago

I see - should be easy to implement analog to the Shelly 2.5:

https://github.com/iobroker-community-adapters/ioBroker.shelly/blob/6e3ee2fd07a8851c2e81e66fa4ddb04f8c6c2e19/lib/devices/gen1/shellyswitch25.js#L828

https://github.com/iobroker-community-adapters/ioBroker.shelly/blob/6e3ee2fd07a8851c2e81e66fa4ddb04f8c6c2e19/lib/devices/gen1/shellyswitch25.js#L845

HGlab01 commented 1 year ago

Thanks, for the quick enhancement. Works fine!