ionelmc / cookiecutter-pylibrary

Enhanced cookiecutter template for Python libraries.
BSD 2-Clause "Simplified" License
1.25k stars 207 forks source link

Duplicated coverage report on COVERALLS #158

Closed joaomcteixeira closed 1 year ago

joaomcteixeira commented 5 years ago

Hi @ionelmc

quick words of introduction: I have been reading during the last days through your documentation, posts and projects related to this cookiecutter and packaging strategy. In the beginning every line was new information and I could only learn it going line by line and build my own skeleton repository the hard way. I really support your strategy!

Going to the issue:

I generated this repo from this cookiecutter. As is, the coverage information is reported twice to COVERALLS, coming from both Travis and Appveyor, rendering this awkward output of duplicated file information.

I encountered this same behavior during the first commits of my first skeleton repository (mentioned above). Finally I solved it after restricting sending coverage reports only through Travis (see .travis.yml) and removing env:coverage and env:coveralls from tox.in.

first question: Where is travis sending coverage information to coveralls? Is it through the env:coveralls ? (same to codecov?)

question 2: why sending coverage information from both appveyor and travis?

solution: depending on your answers, can this be changed in the coockiecutter template?

Thank you!

ionelmc commented 5 years ago
  1. Yes, it's coveralls env in tox.ini

  2. Looks like there is an issue with how coveralls is merging the report from appveyor (looks like it doesn't merge at all 😞 - imo this is a bug in coveralls). I've recently added the coveralls support in the appveyor configuration, maybe I should have added with with a disable flag. Alternatively we can just change the template a bit so if coveralls_token ain't set then it's disabled in appveyor (it won't work without the token anyway).

joaomcteixeira commented 5 years ago
ionelmc commented 1 year ago

Coveralls has been switched to their new github action. Open new issue if there's a problem with that.