search

ionelmc / python-redis-lock

Lock context manager implemented via redis SET NX EX and BLPOP.
https://pypi.python.org/pypi/python-redis-lock
BSD 2-Clause "Simplified" License
551 stars 77 forks source link

Simplify Tox configuration #23

Closed AndreiPashkin closed 8 years ago

AndreiPashkin commented 9 years ago

Replaces copy-pasted Tox environments with parametrized environments.

ionelmc commented 9 years ago

Currently tox.ini is generated from this: https://github.com/ionelmc/python-redis-lock/blob/master/setup.cfg#L63-L86 (with a template in ci/templates). Not sure if generative tox config can reproduce that matrix ....

AndreiPashkin commented 9 years ago

Wow, I didn't noticed that, looks nice. The point is - run Django-related tests on any Python except 2.6? If yes - Tox can do that.

AndreiPashkin commented 9 years ago

I also think, that there is no need to have virtual envs with and without coverage, running tests and collect ing coverage data at the same time should be ok and it will be speed up CI.

ionelmc commented 9 years ago

I have been burnt in the past by issues (like race condition) creeping up only when coverage is on or vice-versa.

Thanks, -- Ionel Cristian Mărieș, http://blog.ionelmc.ro

On Sat, Nov 28, 2015 at 2:02 PM, Andrew pashkin notifications@github.com wrote:

I also think, that there is no need to have virtual envs with and without coverage, run tests and collect coverage at the same time should be ok and it will be speed up CI.

— Reply to this email directly or view it on GitHub https://github.com/ionelmc/python-redis-lock/pull/23#issuecomment-160287733 .