Closed ionelmc closed 8 years ago
@ionelmc What do you think about remove this check too https://github.com/ionelmc/python-redis-lock/blob/remove-unnecessary-held-check/src/redis_lock/__init__.py#L161 ?
It opens the possibility to use a fake/dummy redis server implementation1 to write unittests without a real redis instance.
@georgeyk Hmm, we could remove it. Do you need that removal for your own test suite or something like that?
@ionelmc yes, I think fakeredis might work with python-redis-lock.
I'm not testing the lock itself, but the code that is executed with the lock.
@@ master #49 diff @@
=====================================
Files 2 2
Lines 170 168 -2
Methods 0 0
Branches 26 25 -1
=====================================
Hits 156 156
+ Misses 8 7 -1
+ Partials 6 5 -1
...dis_lock/__init__.py
was modified. more
-1
-1
+2
Powered by Codecov. Last updated by 71a125b
@georgeyk ok, check this new change.
LGTM :+1:
Ref #48.