ionic-team / vscode-ionic

Visual Studio Code Ionic Extension
Other
10 stars 1 forks source link

"[error] Unable to determine the framework type" introduced in v1.92 #179

Closed wsamoht closed 1 month ago

wsamoht commented 1 month ago

PR #174 introduced the following error message here.

Unable to determine the framework type for ${project.name}

Having this error message is causing the Output panel of VS Code to be focused for any non Ionic project. I even opened up a completely empty folder and this error gets thrown.

I would argue that this error message is a little too aggressive.

What are your thoughts on changing this to a warning and/or changing the logging.ts logic to have an option to not call channel.show() when logging a message?

Also, maybe don't call channel.show() at all if a warning.

dtarnawsky commented 1 month ago

Resolved in 1.92.1