For developers and testers. 8.3.3 version

[Shadowss]

We must a full evaluation of the entire version and put all bugs in 1 posts. To see what bugs is still remaining and what need testings.

• [x] Capture and re-capture of the village by the leaders

  • [x] Conducting the capture of the village all the slots for the foundation of the village, in the captured village, are cleared and it is possible to build new leaders and settlers. Slots should not be cleared if a village has already been established or captured from this village. The following applies here. If we did a re-capture then the slot in the old village is not released. It turns out that one village we founded or captured from several villages.

• [x] Oases

  • [x] Oases do not always have the resources for the farm, if they belong to nature.
  • [x] If we destroy the village from which the oasis was seized, then the oasis remains tied to that cachet. In fact, if another player in that free cage builds a village that oasis will belong to the old player and give a resource bonus to the village that already belongs to the new player. The same situation with the seizure of the village. If you seize the village, then the oasis belongs to the old player and the resources give to that village (I do not remember how it should be, perhaps an oasis must return to the possession of nature).

• [x] Construction of chiefs and settlers

  • [x] Now we have the opportunity to build either leaders or settlers. It should be possible to build the leaders and settlers together.
  • [x] Trapped settlers/chiefs aren't counted as used slots.
  • [x] Attacking/reinforcing settlers/chiefs of other players, are counted (erroneously) as used slots.

• [x] Hero

  • [x] After I sent a hero to the reinforcements with the troops, destroying the village, the hero with the troops disappeared and the tavern shows that the hero is alive. A real bug.

• [x] Medals

  • [x] The first medals are issued after 14 days, if the issue is established after 7 days.
  • [x] The issuance of medals is counted from the start date of the server and not from Monday to Sunday as it should be #381
  • [x] Players such as Multihunter, Support, Nature, Natars participate in the issuance of medals.

• [x] Rally Point

  • [x] Time counting in outgoing rally point attacks does not work if we have Incoming Troops
  • [x] Show the last destroyed target before the inscription "The village has been destroyed" #402
  • [x] You can see troops movement, send attacks, enforcements, raids and scouts with a level 0 rally point.

• [x] General building bugs

  • [x] You can train troops even without the needed building (Barracks, Stable, Workshop, Residence, Castle and so on)
  • [x] If you damage with catapults a building in costruction, the building level isn't decreased/removed from the building queue (if brought to 0).
  • [x] Blacksmith and Armoury don't have a research queue with a plus account.
  • [x] The master builder timer is bugged if a building is removed from the construction queue, with 2 or more building in the queue.
  • [x] When removing a building construction with a master builder order active of the same, a level have to be removed from that order construction
  • [x] When removing a building construction of the same type, with a master builder order active, the construction time became wrong
  • [x] A building could be increased by 2 level at random.
  • [x] You can put 2 buildings in the building queue even without a plus account (only for Romans)
  • [x] Sometimes 3x doesn't work in the marketplace.
  • [x] You can't finish all buildings, researches, etc. without a plus account

• [x] General Attack bugs

  • [x] Blacksmith and Armoury ups are counted wrongly during a battle.
  • [x] The Trapper formula isn't coded.
  • [x] Spies will be trapped if in the attacked village there will be at least one spying unit.
  • [x] Morale bonus isn't counted while chiefing.
  • [x] Big party isn't counted while chiefing.
  • [x] Brewery isn't counted while chiefing.
  • [x] Brewery isn't counted while attacking with catapults.
  • [x] Troops don't die if sent in an attack with a negative value of crop.
  • [x] Trapped troops in other villages don't die with a negative crop production a 0 or less of crop.
  • [x] You can spy a village with not-spy troops.
  • [x] If you reinforce a village two times, two different reinforces will be created, instead of merging them in one
  • [x] If more than one enforcements arrive at the same seconds, only the first one will be counted, the others will disappear
  • [x] 25% of trapped troops should die when released.
  • [x] Traps shouldn't be added immediately after the releasing of the troops, they should be added to the training list.
  • [x] Rams don't work as they should (the destruction of the wall doesn't get considered in a battle).

• [x] General Artifact bugs

  • [x] Artifact chronology isn't coded yet.
  • [x] The artifact of the slight fool doesn't work.#452
  • [x] Some artifacts don't work properly.
  • [x] You can't conquer an artifact from one of your villages, if you've already the maximum amount of artifacts.
  • [x] Artifacts should be activated after 24 hours (x1 speed) and not immediately after the conquest. #451
  • [x] Artifacts (and WW villages) should spawn in the map after some amount of days from the start of the server.
  • [x] Villages with 0 pop, aren't destroyed after conquering an artifact.
  • [x] If you conquer a village with an artifact inside, the owner of that artifact doesn't change automatically.
  • [x] Any player may only capture 1 artefact with an unique or account scope. Any player may only capture up to 3 artefacts "at once". Players may own more than one unique/account artefact resp. more than 3 artefacts in total by conquering. Only 3 artefacts are active out of which only 1 can be unique or have an account wide effect. In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active. If player has 3 village scope artefacts and conquers a fourth with an account scope effect, the third (most recent) village scope artefact gets deactivated, and instead of it the fourth artefact will get active after the countdown.
  • [x] Crop consumption in WW villages must be halved.
  • [x] Artifact text must be modified.
  • [x] Stronger buildings artifact, shouldn't work for WWs.

• [x] Profile bugs

  • [x] There are several security issues which need to be adressed.
  • [x] Direct Links don't work.

• [x] Admin panel

  • [x] Tribe percentages are wrong, in the "Server info" section.
  • [x] NewsBoxes should be editable in the Admin Panel (to announce events).

• [x] Bugs in the alliance

  • [x] The forum is completely hackable
  • [x] You can found an ally without the embassy or with a level 1 or 2 embassy.
  • [x] You can found another alliance while being in an ally.
  • [x] You can set the max numbers of players during the creation of an ally, by hacking the passed building id.
  • [x] You can kick members of other alliances.
  • [x] Send message to all alliance members #276.
  • [x] Errors aren't shown correctly in some parts of the alliance.
  • [x] You can offer more than three confederation/NAP pacts.
  • [x] You can offer the same pact to an alliance that have already sent it to you.
  • [x] You can change the forum link and diplomacy without permissions.
  • [x] Some parts of the alliance are hackable. (Invitation system, delete invite, delete diplomacy, etc.).
  • [x] You can access to an alliance informations (forum, chat, reports, etc.) without being in it.
  • [x] You can access to some options menu without having the right permissions.

• [x] Bugs in the market

  • [x] You can offer inexistent types of resources
  • [x] Trade routes are hackable
  • [x] You can send resources to the same village they're
  • [x] You can accept offerings from the same village they're made
  • [x] You can accept offerings without the needed merchants
  • [x] You can accept offerings without enough resources
  • [x] You can accpet offerings with a too high maxtime
  • [x] You can gain an infinite amount of resources by offering a lot of resources, then offer 1 resource and delete the offering.

• [x] General bugs

  • [x] In dorf3.php, troops in training are shown multiple times.
  • [x] You can visualize an inexistent corrupted village in the map.
  • [x] If you log in after some time, your resources are resetted to 0 at random (it happens more frequently in high speed servers)
  • [x] If the hero dies in an attack, the return time of the troops, will be wrong.
  • [x] Attacking spies don't die if they're detected by reinforcement spies.
  • [x] Trapped troops won't return to the correct villages.
  • [x] Trapped troops can't be released with prisoners from more than one villages.
  • [x] Released troops are counted wrongly.
  • [x] Stolen resources are calculated wrongly.
  • [x] If a settling is canceled, settlers have to return with 750 for each resource type.
  • [x] Resources aren't updated correctly #253 #496.

• [x] Reports bug

  • [x] The number of files in the Notice folder needs to be reduced (for a bettere maintainability)
  • [x] Some .tpl report files can be reduced of about 250 lines of code with a foreach
  • [x] Heroes aren't shown correctly if they're reinforcing a village
  • [x] Heroes should be divided by tribe in the report
  • [x] Reinforcements of the same tribe of the reinforced user, should be separated in the report
  • [x] Festive reports cannot be opened from the alliance
  • [x] Viewing a player's village when attacking a player with an alliance during a peace system.
  • [x] Festive report are doubled in the alliance.

• [x] Raid list bugs

  • [x] You can attack yourself (the same village you started the farm list).
  • [x] You can't attack an oasis.
  • [x] You can save a raid list with 0 troops.
  • [x] Raid lists can be deleted by anyone.
  • [x] Raid lists can be edited by anyone.
  • [x] Raid lists can be saved in other players' lists
  • [x] Raid lists can be started by anyone.
  • [x] The whole "Farm list" section, has an incorrect graphic.
  • [x] Connected raid lists should be deleted when deleting a farm list

• [x] Alliance forum bugs

  • [x] Forums can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] Threads can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] Posts can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] You can create a forum with an empty topic and/or description.
  • [x] You can create a thread with an empty topic and/or text.
  • [x] You can create a post with an empty topic and/or text.
  • [x] "Move forum to the top/bottom" hasn't been coded yet.
  • [x] Anyone can access to any forum, threads and post.
  • [x] Anyone can create threads and post to any forum
  • [x] Public forum forums aren't displayed in the forum list.
  • [x] Shared forum forums aren't displayed in the forum list.
  • [x] Confederation forums aren't displayed in the forum list.

And other bugs I didn't find yet or that I forgot.

[iopietro]

Yep, we can do it!

[iopietro]

Lol, sorry, i missclicked.

[fritz-net]

• Units are more often than 1 time in Village Overview

• If there are many many many reports the selector pages do not work (Error 500) when using the GET t parameter

[Shadowss]

Yeah , I can confirm

[iopietro]

Added to the list.

[RevertIT]

I'll make CSS + clean image with photoshop for: Add a message when you release artefacts see this

The only thing you gonna add is a text

[iopietro]

@phaze1G, Nice! It would be cool :)!

[RevertIT]

@iopietro do you have a text in English which should be there?

[iopietro]

Yeah, you can use the text written by shadowss about 14-15 comments ago.

[velhbxtyrj]

The text must be added directly to the code itself, so that it would be possible to translate into different languages.

[iopietro]

I agree, the text should be hardcoded into a constant (in en.php).

[RevertIT]

@velhbxtyrj @iopietro I have completed my task. Feel free to implement it as you wish http://jsfiddle.net/EgLKV/9515/

Edit: updated class's and ID's so there won't be a CSS issue with duplicates.

[velhbxtyrj]

Good job, thank you :)

[iopietro]

Thanks a lot :)!

[RevertIT]

The link color is #800000 <a href="/link"><font color="#800000">» Continue</font></a>

[Shadowss]

Must to be implemented like an automatic message. Shoud be looks like winner.php

[TerraSkye]

making some good progress guys!

[iopietro]

@Shadowss, I already have in mind something about that.

[Shadowss]

@iopietro : can you implement this code in an automated message ?

Code : http://jsfiddle.net/EgLKV/9515/

[iopietro]

I'll do it in the Natars automatic system

[velhbxtyrj]

@iopietro

NewsBoxes should be editable in the Admin Panel (to announce events).

Can this be a solution to the problem?

[Shadowss]

Yeah , it`s good. But also must to create automated message like WW winning.

[velhbxtyrj]

It's clear. But sending an automatic message is another issue :)

If my proposal is suitable for the output of information about the peace system, I will implement it.

[iopietro]

@velhbxtyrj, Yes, it can be a solution for that problem, it's a good idea, you can implement it if you want.

[RevertIT]

If you have more work for CSS or editing images I can assign myself to it.

[eliopinho]

i make this if you want alternatives for classic style messages

[RevertIT]

@eliopinho I made a CSS container for the provided image. Thanks for that image.

http://jsfiddle.net/phaze1G/EgLKV/9574/

Edit: "continue" link included.

[iopietro]

Nice work guys :)!

[Shadowss]

Great , but can you modify the photo with something more appropriate by artefacts ? Maybe @iopietro can implement this when is released the artefacts.

[eliopinho]

[RevertIT]

The second one is the best.

[eliopinho]

another :)

[velhbxtyrj]

@iopietro Perhaps this need to be removed? https://github.com/Shadowss/TravianZ/blob/600c762c8e723c86e3c1e9b82a333fb5e54ba98e/Templates/menu.tpl#L106

This is displayed in row 69

[iopietro]

Yep, removed.

[velhbxtyrj]

Some warnings:

Warning: include(Templates/Notice/22x.tpl): failed to open stream: No such file or directory in /home/u997437127/public_html/berichte.php on line 109

Warning: include(): Failed opening 'Templates/Notice/22x.tpl' for inclusion (include_path='.:/opt/php-7.0/pear') in /home/u997437127/public_html/berichte.php on line 109

During the peace, the target as a multihunter

When you click on a link displays warning

edit: The attack was performed not on a multihunter but on another player

[iopietro]

@fritz-net, Fixed your reported bug in 559ac720a2ec0f2562238849a28c6e7c393f4f22.

[iopietro]

@velhbxtyrj, Because 22x doesn't exist, I think we should also reduce the number of files in the notice folder and do a reports rework, because 90% of files in that folder, are equal to each other.

[velhbxtyrj]

But I think this is most likely an incorrect redirect. Because it should redirect to this kind of report.

[iopietro]

Yes, that's an incorrect redirect, what's the type number of that report?

[velhbxtyrj]

@iopietro But notice one more thing. Incorrect display of information on whom the attack was performed. I attacked another player. And the statistics shows a multihunter.

[iopietro]

Yeah, that's another bug.

[velhbxtyrj]

Perhaps these warnings also arise due to the fact that the wrong conclusion in the statistics?

[iopietro]

I don't think so, it's only a redirect to an inexistent file.

[iopietro]

@velhbxtyrj, I fixed the first bug in 8dd8fc236415fda24340f4cd9c77dff4c34f360b and 2d573a9, for the second one I need to rework all reports.

[velhbxtyrj]

I made a copy of the file 22.tpl and called it 22x.tpl. And everything works as it should. Maybe this is the solution to the problem?

[velhbxtyrj]

So is another problem. If the player is without an alliance or is in another alliance, then the report in the statistics of the alliance attacks and in the statistics of attacks on the village is one, if the player is in our alliance then the record is duplicated. One is displayed correctly and the second without dates and with information about what the Multihunter attacked an unknown village.

This also applies to the included peace system

[iopietro]

Yeah, that's a solution, but I didn't want to do it because I want to reduce the notice files. I'll want to merge alliance(__x.tpl) files into normal notice files. I'll look into the reports duplication bug.

[fritz-net]

@iopietro, thx for fixing this ... I also noticed, that in dorf3.php the top most village is always highlighted not the active one

[velhbxtyrj]

Scouts show Gauls Cranny places the same as the Cranny of Romans and Teutons. Gauls Cranny more than twice.

[iopietro]

@velhbxtyrj Fixed in de8859da03646cec14c6d8b404e676c637c66a4f.