For developers and testers. 8.3.3 version

[Shadowss]

We must a full evaluation of the entire version and put all bugs in 1 posts. To see what bugs is still remaining and what need testings.

• [x] Capture and re-capture of the village by the leaders

  • [x] Conducting the capture of the village all the slots for the foundation of the village, in the captured village, are cleared and it is possible to build new leaders and settlers. Slots should not be cleared if a village has already been established or captured from this village. The following applies here. If we did a re-capture then the slot in the old village is not released. It turns out that one village we founded or captured from several villages.

• [x] Oases

  • [x] Oases do not always have the resources for the farm, if they belong to nature.
  • [x] If we destroy the village from which the oasis was seized, then the oasis remains tied to that cachet. In fact, if another player in that free cage builds a village that oasis will belong to the old player and give a resource bonus to the village that already belongs to the new player. The same situation with the seizure of the village. If you seize the village, then the oasis belongs to the old player and the resources give to that village (I do not remember how it should be, perhaps an oasis must return to the possession of nature).

• [x] Construction of chiefs and settlers

  • [x] Now we have the opportunity to build either leaders or settlers. It should be possible to build the leaders and settlers together.
  • [x] Trapped settlers/chiefs aren't counted as used slots.
  • [x] Attacking/reinforcing settlers/chiefs of other players, are counted (erroneously) as used slots.

• [x] Hero

  • [x] After I sent a hero to the reinforcements with the troops, destroying the village, the hero with the troops disappeared and the tavern shows that the hero is alive. A real bug.

• [x] Medals

  • [x] The first medals are issued after 14 days, if the issue is established after 7 days.
  • [x] The issuance of medals is counted from the start date of the server and not from Monday to Sunday as it should be #381
  • [x] Players such as Multihunter, Support, Nature, Natars participate in the issuance of medals.

• [x] Rally Point

  • [x] Time counting in outgoing rally point attacks does not work if we have Incoming Troops
  • [x] Show the last destroyed target before the inscription "The village has been destroyed" #402
  • [x] You can see troops movement, send attacks, enforcements, raids and scouts with a level 0 rally point.

• [x] General building bugs

  • [x] You can train troops even without the needed building (Barracks, Stable, Workshop, Residence, Castle and so on)
  • [x] If you damage with catapults a building in costruction, the building level isn't decreased/removed from the building queue (if brought to 0).
  • [x] Blacksmith and Armoury don't have a research queue with a plus account.
  • [x] The master builder timer is bugged if a building is removed from the construction queue, with 2 or more building in the queue.
  • [x] When removing a building construction with a master builder order active of the same, a level have to be removed from that order construction
  • [x] When removing a building construction of the same type, with a master builder order active, the construction time became wrong
  • [x] A building could be increased by 2 level at random.
  • [x] You can put 2 buildings in the building queue even without a plus account (only for Romans)
  • [x] Sometimes 3x doesn't work in the marketplace.
  • [x] You can't finish all buildings, researches, etc. without a plus account

• [x] General Attack bugs

  • [x] Blacksmith and Armoury ups are counted wrongly during a battle.
  • [x] The Trapper formula isn't coded.
  • [x] Spies will be trapped if in the attacked village there will be at least one spying unit.
  • [x] Morale bonus isn't counted while chiefing.
  • [x] Big party isn't counted while chiefing.
  • [x] Brewery isn't counted while chiefing.
  • [x] Brewery isn't counted while attacking with catapults.
  • [x] Troops don't die if sent in an attack with a negative value of crop.
  • [x] Trapped troops in other villages don't die with a negative crop production a 0 or less of crop.
  • [x] You can spy a village with not-spy troops.
  • [x] If you reinforce a village two times, two different reinforces will be created, instead of merging them in one
  • [x] If more than one enforcements arrive at the same seconds, only the first one will be counted, the others will disappear
  • [x] 25% of trapped troops should die when released.
  • [x] Traps shouldn't be added immediately after the releasing of the troops, they should be added to the training list.
  • [x] Rams don't work as they should (the destruction of the wall doesn't get considered in a battle).

• [x] General Artifact bugs

  • [x] Artifact chronology isn't coded yet.
  • [x] The artifact of the slight fool doesn't work.#452
  • [x] Some artifacts don't work properly.
  • [x] You can't conquer an artifact from one of your villages, if you've already the maximum amount of artifacts.
  • [x] Artifacts should be activated after 24 hours (x1 speed) and not immediately after the conquest. #451
  • [x] Artifacts (and WW villages) should spawn in the map after some amount of days from the start of the server.
  • [x] Villages with 0 pop, aren't destroyed after conquering an artifact.
  • [x] If you conquer a village with an artifact inside, the owner of that artifact doesn't change automatically.
  • [x] Any player may only capture 1 artefact with an unique or account scope. Any player may only capture up to 3 artefacts "at once". Players may own more than one unique/account artefact resp. more than 3 artefacts in total by conquering. Only 3 artefacts are active out of which only 1 can be unique or have an account wide effect. In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active. If player has 3 village scope artefacts and conquers a fourth with an account scope effect, the third (most recent) village scope artefact gets deactivated, and instead of it the fourth artefact will get active after the countdown.
  • [x] Crop consumption in WW villages must be halved.
  • [x] Artifact text must be modified.
  • [x] Stronger buildings artifact, shouldn't work for WWs.

• [x] Profile bugs

  • [x] There are several security issues which need to be adressed.
  • [x] Direct Links don't work.

• [x] Admin panel

  • [x] Tribe percentages are wrong, in the "Server info" section.
  • [x] NewsBoxes should be editable in the Admin Panel (to announce events).

• [x] Bugs in the alliance

  • [x] The forum is completely hackable
  • [x] You can found an ally without the embassy or with a level 1 or 2 embassy.
  • [x] You can found another alliance while being in an ally.
  • [x] You can set the max numbers of players during the creation of an ally, by hacking the passed building id.
  • [x] You can kick members of other alliances.
  • [x] Send message to all alliance members #276.
  • [x] Errors aren't shown correctly in some parts of the alliance.
  • [x] You can offer more than three confederation/NAP pacts.
  • [x] You can offer the same pact to an alliance that have already sent it to you.
  • [x] You can change the forum link and diplomacy without permissions.
  • [x] Some parts of the alliance are hackable. (Invitation system, delete invite, delete diplomacy, etc.).
  • [x] You can access to an alliance informations (forum, chat, reports, etc.) without being in it.
  • [x] You can access to some options menu without having the right permissions.

• [x] Bugs in the market

  • [x] You can offer inexistent types of resources
  • [x] Trade routes are hackable
  • [x] You can send resources to the same village they're
  • [x] You can accept offerings from the same village they're made
  • [x] You can accept offerings without the needed merchants
  • [x] You can accept offerings without enough resources
  • [x] You can accpet offerings with a too high maxtime
  • [x] You can gain an infinite amount of resources by offering a lot of resources, then offer 1 resource and delete the offering.

• [x] General bugs

  • [x] In dorf3.php, troops in training are shown multiple times.
  • [x] You can visualize an inexistent corrupted village in the map.
  • [x] If you log in after some time, your resources are resetted to 0 at random (it happens more frequently in high speed servers)
  • [x] If the hero dies in an attack, the return time of the troops, will be wrong.
  • [x] Attacking spies don't die if they're detected by reinforcement spies.
  • [x] Trapped troops won't return to the correct villages.
  • [x] Trapped troops can't be released with prisoners from more than one villages.
  • [x] Released troops are counted wrongly.
  • [x] Stolen resources are calculated wrongly.
  • [x] If a settling is canceled, settlers have to return with 750 for each resource type.
  • [x] Resources aren't updated correctly #253 #496.

• [x] Reports bug

  • [x] The number of files in the Notice folder needs to be reduced (for a bettere maintainability)
  • [x] Some .tpl report files can be reduced of about 250 lines of code with a foreach
  • [x] Heroes aren't shown correctly if they're reinforcing a village
  • [x] Heroes should be divided by tribe in the report
  • [x] Reinforcements of the same tribe of the reinforced user, should be separated in the report
  • [x] Festive reports cannot be opened from the alliance
  • [x] Viewing a player's village when attacking a player with an alliance during a peace system.
  • [x] Festive report are doubled in the alliance.

• [x] Raid list bugs

  • [x] You can attack yourself (the same village you started the farm list).
  • [x] You can't attack an oasis.
  • [x] You can save a raid list with 0 troops.
  • [x] Raid lists can be deleted by anyone.
  • [x] Raid lists can be edited by anyone.
  • [x] Raid lists can be saved in other players' lists
  • [x] Raid lists can be started by anyone.
  • [x] The whole "Farm list" section, has an incorrect graphic.
  • [x] Connected raid lists should be deleted when deleting a farm list

• [x] Alliance forum bugs

  • [x] Forums can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] Threads can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] Posts can be edited, modified and deleted by anyone, from any alliance and with any kind of permission.
  • [x] You can create a forum with an empty topic and/or description.
  • [x] You can create a thread with an empty topic and/or text.
  • [x] You can create a post with an empty topic and/or text.
  • [x] "Move forum to the top/bottom" hasn't been coded yet.
  • [x] Anyone can access to any forum, threads and post.
  • [x] Anyone can create threads and post to any forum
  • [x] Public forum forums aren't displayed in the forum list.
  • [x] Shared forum forums aren't displayed in the forum list.
  • [x] Confederation forums aren't displayed in the forum list.

And other bugs I didn't find yet or that I forgot.

[iopietro]

@fritz-net Fixed in bd38ac7fd8861cbcd46348ed386c1ccc8d8420c7.

[eliopinho]

@iopietro can you group reenforcements at rally point ?

if you send multiplous reenforcements from the same village , should group all troops in only one.. (even the reports , when the troops are attacked, you receive multiplous reports..)

should only receive one report per troops and village.

[iopietro]

@eliopinho, Fixed in bf091c2a0ce917cbc1fffcb5eeaca11365fb01ea.

[eliopinho]

thks a lot

[Shadowss]

Great , thanks a lot for all. We are almost there , we are a half road on that section.

Maybe you can try to fix General building bugs and Artefacts next. But you know better what is next. It`s just an ideea

[iopietro]

First I'll rework the report system, there are too many duplicate files in the notice folder, I'll delete about 80% of them. Then I'll move into fixing artefacts and after general building bugs.

[Shadowss]

Huston we have a problem.

I attack @velhbxtyrj World of Wonder , the reports is correct but not counted in TOP 10.

[Shadowss]

Another problem in PARADISE , when hero died , and enter in Admin panel to revive in here :

And press revive , nothing is happened. Hero must to revive in the CAPITAL.

[velhbxtyrj]

Not included are attack points

[Shadowss]

New bug added in Artifact Section :

Any player may only capture 1 artefact with an unique or account scope. Any player may only capture up to 3 artefacts "at once". Players may own more than one unique/account artefact resp. more than 3 artefacts in total by conquering. Only 3 artefacts are active out of which only 1 can be unique or have an account wide effect. In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active. If player has 3 village scope artefacts and conquers a fourth with an account scope effect, the third (most recent) village scope artefact gets deactivated, and instead of it the fourth artefact will get active after the countdown.

@velhbxtyrj : maybe you update the list with thees bugs please (exclude Artifact Bug , i already put it on first post). Thanks

[iopietro]

I'll look into it, the problem with Automation.php (and in particular, the function "sendunitsComplete") is that it's very huuuuuge. Automation.php has about 7k lines of code and sendunitsComplete 2k, that's very bad because the maintanability is very low, so if I change something significant in the code, I risk to break everything, lol.

[velhbxtyrj]

Need to look in your last change. This is due to reports. I just reloaded all the old files on the hosting and everything works :)

[iopietro]

Yep, I fixed it internally, I'll push the commit later today, with the report refactor part 2.

[iopietro]

Fixed in c2f4d43b7ef435133ef67ae90df09fd988ed7902.

[velhbxtyrj]

During the attack on Natars. This is due to the destruction of targets by catapults.

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5119

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5121

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5122

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5131

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5132

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5121

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5122

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5131

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5132

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5121

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5122

Warning: Illegal string offset 'oldrank' in /home/u997437127/public_html/GameEngine/Automation.php on line 5131

Warning: Illegal string offset 'userid' in /home/u997437127/public_html/GameEngine/Automation.php on line 5132

[iopietro]

Should be fixed in 970387342a7f8603992ed8709dfae3d13fab0e05.

Another thing, I don't think that "duplicated reports in the alliance" is a bug, because if i remember correctly it was present in the original travian.

[Shadowss]

Yes it's in the original version

[iopietro]

Ok, so I'll remove it from the bug list.

[velhbxtyrj]

Please watch this video.

[iopietro]

Ok, I miserunderstood, I thought you meant another thing, I'll fix that.

[velhbxtyrj]

I also thought that you thought about where the sword and shield are displayed ) so I decided to show it visually )

[iopietro]

Fixed in 996f0116665ae71e417be2472ec832d10d21bf37.

[velhbxtyrj]

I robbed an oasis and was able to carry out 8,000 of each resource. Must be 800 in fact?

[iopietro]

Resources in oasis scale with the "STORAGE_MULTIPLIER" constant.

[velhbxtyrj]

I suspected this) Just thought that it depends on the speed of the server :)

[Shadowss]

Good morning guys.

@iopietro : what's next ?

[iopietro]

Good morning, artifacts are my next target. I need to create a new table in the database for artifacts chronology.

[Shadowss]

@iopietro : don't forget about this : Any player may only capture 1 artefact with an unique or account scope. Any player may only capture up to 3 artefacts "at once". Players may own more than one unique/account artefact resp. more than 3 artefacts in total by conquering. Only 3 artefacts are active out of which only 1 can be unique or have an account wide effect. In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active. If player has 3 village scope artefacts and conquers a fourth with an account scope effect, the third (most recent) village scope artefact gets deactivated, and instead of it the fourth artefact will get active after the countdown.

[velhbxtyrj]

I would single out this item only. Because the strikethrough already works.

~Any player may only capture 1 artefact with an unique or account scope. Any player may only capture up to 3 artefacts "at once". Players may own more than one unique/account artefact resp. more than 3 artefacts in total by conquering.~ Only 3 artefacts are active out of which only 1 can be unique or have an account wide effect. In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active. If player has 3 village scope artefacts and conquers a fourth with an account scope effect, the third (most recent) village scope artefact gets deactivated, and instead of it the fourth artefact will get active after the countdown.

[Shadowss]

Wrong

Unique diet control (50%) Treasury 20, Effect account

Great storage masterplan (GG&GW) Treasury 20, Effect account

Artefact of the unique fool Treasury 20, Effect account

All are active !!

[iopietro]

You've 4 artifacts because you conquered "Ancient Construction plan" before I fixed the possibility to conquer it even with the maximum number of artifacts (3). The artifact activation part isn't in the "barred" part of velhbxtyrj's message.

[Shadowss]

Ahh ok. Must to reinstall all server and restart. But only after you fix all artifacts bug

[velhbxtyrj]

@Shadowss The server does not need to be reinstalled. Just go to another account and try to capture the artifacts. The hero will not be able to capture more than one artifact (large or unique) and in total more than three (one large or unique and two small). The rest of the artifacts can be captured only by capturing the settlement with the located artifact of the leaders. At this stage, just need to fix the work of the captured artifacts as it is painted in the fact that I left it not crossed out :).

[fritz-net]

When I open http://travian.shadowss.ro/berichte.php?t=2 I get an Error 500. When I open the page without the get attributes all is fine. This only happens when I have a lot of reports

[agony09]

i have try this link. it works fine. no Error 500. is Reports, Trade

[iopietro]

Dunno, it could be a timing out error. @Shadowss You should check your error logs for more infos about that.

[fritz-net]

I don't think its a timeout since its very fast. The link also works fine if I change account

[Shadowss]

Works for me , sorry

[Shadowss]

[23-Apr-2018 19:45:30 Europe/Bucharest] PHP Warning: unlink(GameEngine/Prevention/market.txt): No such file or directory in /home/outlet/public_html/shadowss.ro/travian/GameEngine/Automation.php on line 1007 [23-Apr-2018 20:28:37 Europe/Bucharest] PHP Warning: unlink(GameEngine/Prevention/demolition.txt): No such file or directory in /home/outlet/public_html/shadowss.ro/travian/GameEngine/Automation.php on line 4483 [23-Apr-2018 20:28:37 Europe/Bucharest] PHP Warning: unlink(GameEngine/Prevention/market.txt): No such file or directory in /home/outlet/public_html/shadowss.ro/travian/GameEngine/Automation.php on line 1007 [23-Apr-2018 20:29:08 Europe/Bucharest] PHP Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) in /home/outlet/public_html/shadowss.ro/travian/GameEngine/Database.php on line 642 [23-Apr-2018 21:49:40 Europe/Bucharest] PHP Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes) in /home/outlet/public_html/shadowss.ro/travian/GameEngine/Database.php on line 642

[iopietro]

I don't understand what does he mean with this phrase: "In case there are 2 account wide effect artefacts amongst your 3 oldest artefacts the fourth oldest will become active.", if I have 3 artifacts among which 2 unique, how could the fourth artifact activates, if I've not a fourth artifact?

[velhbxtyrj]

Work should only three artifacts, which were captured first. All other artifacts should not work. Now all the artifacts work. You can refer to this help: http://travian.wikia.com/wiki/Artifacts

[velhbxtyrj]

I will also add that only one unique or large artifact should work. But now if we have two or more they all work.

[fritz-net]

@Shadowss, sure it is working for you since you don't have this much reports. I also works for me if I have less (unread) reports. And also if I switch to another account I don't have the issue. Just check your error.log for the 500Error

[iopietro]

@velhbxtyrj, Yes, I know, the only problem was in that phrase: If I've 3 artifacts, 2 unique and 1 partial (village effect) which one of the unique should I activate? The oldest one?

[velhbxtyrj]

@iopietro Yes. The oldest (it's the one that we captured the very first).

[eliopinho]

@iopietro after i train some troops the system stay like this..

and no change since that (feew days ago) on the shadowss server

page reloads every second, if i train troops it finish instantly

i do not know how to reproduce that, or what happen, if something on db or cache :thinking:

[iopietro]

It's already fixed in a newer version of the game, probably shadowss' server doesn't have it yet.

[Shadowss]

Server has been fully update.

[velhbxtyrj]

@iopietro @fritz-net is right. With a large number of unread reports, Error 500 on all tabs except the tab all.

Trade | Reinforcement | Attacks | Miscellaneous | Archive -> Error 500

This I was looking at the server @Shadowss.

A little later I'll check it on my server.

[velhbxtyrj]

@iopietro On my server this does not happen. And judging from the error message it's not enough memory size.