Setup smart contract repo

iov-one / ethereum-smart-contracts

IOV's smart contracts for Ethereum

Apache License 2.0

4 stars 2 forks source link

Setup smart contract repo #1

Closed webmaster128 closed 5 years ago

webmaster128 commented 5 years ago

[x] Apache-2 licence (copy from iov core)
[x] No external contributors
[x] Rewrite contract from scratch
[x] TDD?
[x] Focus on Ether only first
[x] Renaming
[x] Events in past tense
[x] Move state into struct
[x] Combine check and checkSecret
[x] Remove Pausable
[x] Linting
[x] Look into etheno [not necessary for now]
[x] Analysis scripts (slither, manticore, truffle-security)
[x] Truffle/ganache
[ ] CI setup (especially for linting)

webmaster128 commented 5 years ago

Looking at the import statements in https://github.com/nomiclabs/truffle-flattener/tree/master/tests/contracts, it seems like truffle (or maybe only truffle-flattener) is able to import the contracts from node_modules automatically. That way we can use OpenZeppelin imports via npm instead of copying the files.

webmaster128 commented 5 years ago

Removed

Further issues:
- [ ]  ERC20 implementation
- [ ]  Use OpenZeppelin
- [ ]  Consider git submodules for OpenZeppelin if enough files
- [ ]  Make Mintable for testing purposes

from the original list in this ticket, which is now covered by #7 and #8

ethanfrey commented 5 years ago

Done. Made CI setup it's own issue #16