Write/check/update rostests - Githubissues

ipa320 / araig_test_stack

Apache License 2.0

0 stars 4 forks source link

Write/check/update rostests #37

Open ipa-kut opened 3 years ago

ipa-kut commented 3 years ago

Test those that exist and make sure they all succeed,
Write those that do not.
For cases where there are test/xxx.test as well as launch/test_xxx.launch, convert the latter to the former if possible.

ipa-rwu commented 3 years ago

Knwon failed test (from https://github.com/ipa320/araig_test_stack/pull/58):

test_diff_pose_temporal_node.test
test_comp_poses_node.test
test_diff_poses_spatial_node
test_goal_interpreter_action

ipa-rwu commented 3 years ago

@ipa-kut Naming and placing test rule:

location of tests: "ros pkg"/tests/
naming: test_"target".test
".test" is quite similar to ".launch", you also can run roslaunch pkg *.test. I would suggest not to create .launch file. It is hard to maintain.

ipa-kut commented 3 years ago

@ipa-kut Naming and placing test rule:

* location of tests: "ros pkg"/tests/

* naming: test_"target".test

* ".test" is quite similar to ".launch", you also can run `roslaunch pkg *.test`.  I would suggest not to create .launch file. It is hard to maintain.

Agreed.