use memcpy to copy color image instead of nested for-loops

ipa320 / softkinetic

This repository holds a ROS driver package for an interactive gesture camera (softkinetic).

23 stars 40 forks source link

Closed youtalk closed 9 years ago

youtalk commented 9 years ago

To speed up streaming of color image, this PR uses std::memcpy to copy array instead of nested for-loops.

corot commented 9 years ago

:+1: I have included this change also in #30 and I get around ~1.5 Hz faster! Thanks, @youtalk

youtalk commented 9 years ago

@corot Oops, okay I got it.

corot commented 9 years ago

No, no! that was not my intention! This PR is fine because it's over hydro_dev, while mine only affects indigo branch!

Please reopen it!

youtalk commented 9 years ago

I see. Anyway, your #30 can be also applied to hydro branch. Hope to merge soon.

floweisshardt commented 9 years ago

did this reach consensus to be OK for merge?

corot commented 9 years ago

:+1:

ipa-flg commented 9 years ago

VR :ok_hand:

corot commented 9 years ago

~1.0 Hz faster!

youtalk commented 9 years ago

@corot Thank you for merging.