ipa320 / softkinetic

This repository holds a ROS driver package for an interactive gesture camera (softkinetic).
23 stars 40 forks source link

Release into Indigo? #40

Open rctoris opened 9 years ago

rctoris commented 9 years ago

We have been using the package on Indigo with Ubuntu 14.04 and we'd like to depend on it with some of our release software. Are there any plans to release this into the build farm soon?

floweisshardt commented 9 years ago

@corot: I can help releasing the repository and get it through the buildfarm. All I need you to do is to push the version you would like to release into the indigo_release_candidate branch (Just open a PR and I'll review and accept according to release aspects).

corot commented 9 years ago

I'm :+1: for release indigo, but I think we have a problem with the softkinetic driver: afaik, it cannot be installed with apt-get, just by hand, so jenkins will always fail to build it. Hopefully I'm wrong and there's a way!

Btw, @rctoris are you using hydro or indigo branch? They're quite different now.

gavanderhoorn commented 9 years ago

@corot: ueye_cam faced similar difficulties. See anqixu/ueye_cam#10, and anqixu/ueye_cam@97cfc9d7 for how they (he) fixed it.

I'm not sure whether this is actually 'best practice', but it is at least something workable.

corot commented 9 years ago

First word to come to my mind is : "intimidating". Doesn't look like an easy solution, and I'm too short of time now to try it. But let's keep this issue open and hopefully me or someone else will find time to try!

Another good reason for waiting is to see whether they succeed! :grin:

gavanderhoorn commented 9 years ago

Well it's just a script that downloads the required files and extracts them. I'm not sure anymore whether SoftKinetic have their downloads behind some registration / login system. In that case, it wouldn't work.

Another good reason for waiting is to see whether they succeed!

That script is actually a copy of the one used in the pointgrey driver, so it has already been used.

Just documenting here.

corot commented 9 years ago

Yes, still needs logging/password for Linux drivers, but not for Windows ones. We could ask them to remove this restriction.

rctoris commented 9 years ago

@corot we are using the indigo_dev branch.

corot commented 9 years ago

Hi, I saw this repo. They don't install automatically the DepthSense SDK but at least confirm that it is installed. We can easily do the same.

gavanderhoorn commented 9 years ago

@corot: isn't that already done in CMakeLists.txt - L8-L16?

corot commented 9 years ago

Right! My bad. Is it ok to release like this? Or we break any ROS convention not providing automatic installing of deps?

gavanderhoorn commented 9 years ago

The issue is (iirc) that you cannot build a deb of this pkg on the buildfarm as the softkinetic sdk is missing there. The build will error out with the message I linked earlier and no deb will be produced.

I'm not sure what the best course of action is. I remember suggesting linking the Softkinetic SDK dynamically (so don't link at build time), which would remove the need for the .so's to be present on the buildfarm (typedefs etc would probably need to be duplicated), and I also remember some discussion around that but I can't find it anymore.

corot commented 9 years ago

Yes... I should have re-read the previous posts before bothering anyone, sorry. Right, this is a blocking point. The solution seems to clone the trick of the people @gavanderhoorn mentioned on the post of Oct 16, 2014, assuming we can download the SDK in the same way.

This can be a good amount of work, plus regular updates for new versions. Do you think is worth the effort and time? I don't know how many people is out there using the Senz3D with ROS, nor if more people would join in case of having release packages. If so, I will at least test the automatic download and installation to ensure it is feasible. If not, there are other, maybe more interesting improvements, as dynamic reconfigure and move filters to a nodelet.

gavanderhoorn commented 9 years ago

I can't comment on the nr of people using the driver. Seeing as this is a source-only pkg, you could perhaps use the graphs/traffic page for some statistics that might provide some insight.

Downloading the sdk on build seems like a viable option, provided it is actually possible with the Sense3D sdk.