search

ipa320 / softkinetic

This repository holds a ROS driver package for an interactive gesture camera (softkinetic).
23 stars 40 forks source link

compile dummy node if the depthsense sdk is not found #59

Closed benmaidel closed 8 years ago

benmaidel commented 8 years ago

necessary for successful travis build reason: the depthsense sdk can not be downloaded without a registered account

ipa-nhg commented 8 years ago

CR: OK

gavanderhoorn commented 8 years ago

Just curious, but what is the point of having Travis running to completion if it is not testing the actual code? The dummy is not exercising any of the functionality implemented, so it seems meaningless that Travis is able to build the repository.

knorth55 commented 8 years ago

I support @gavanderhoorn. it seems meaningless and checking nothing.

benmaidel commented 8 years ago

@gavanderhoorn travil will fail for all packages with an dependency on softkinetic. As long as we are not able to release a working version (e.g. wget depthsense sdk during build process), we need a workaround to be able to release/build package that depend on this one. Another possible solution, and probably the best one, is to include the depthsense sdk or wget the actual version from some server. But for this we the authorization from softkinetic.

ipa-flg commented 8 years ago

maybe to add some insight: We use travis for automatically checking all dependencies/repositories related to our actual robots. Hence, from an organisation's point of view (https://github.com/ipa320), this PR makes sense.

to agree with @gavanderhoorn, just for the sake of this repo alone, it's of course meaningless.

ipa-flg commented 8 years ago

CR: ok

gavanderhoorn commented 8 years ago

Can we then at least record the fact that this is a situation to be reversed if/when the DepthSense SDK can be distributed / accessed / installed alongside the package?

knorth55 commented 8 years ago

at least, someone should add issue for this problem and record this travis situation.

ipa-flg commented 8 years ago

https://github.com/ipa320/softkinetic/issues/61

Please feel free to add issues though.

knorth55 commented 8 years ago

thank you. I'm not sure about this problem so i could not create issue about this problem.