search

ipums / hlink

Hierarchical record linkage at scale
Mozilla Public License 2.0
11 stars 2 forks source link

Working to add checks for duplicated comparison features, feature selection, and column mappings #113

Closed jrbalch543 closed 10 months ago

jrbalch543 commented 10 months ago

This is meant to address one of the GitHub issues. This adds checks for duplicates in those three sections to hopefully prevent against errors later on.

Do these checks look like enough?

jrbalch543 commented 10 months ago

For some reason, this isn't letting me make it a draft right now...but I am adding additional tests. Also, no clue why I made the name of the branch same_output. So this is a draft, I haven't forgotten that.

jrbalch543 commented 10 months ago

Ok, now it's ready

riley-harper commented 10 months ago

This is for issue #50.

jrbalch543 commented 10 months ago

I'm realizing I didn't actually address the big top comment and only the little ones

riley-harper commented 10 months ago

Doing some more testing of this this morning. I think we may need a few more changes. Not ready to merge yet.

jrbalch543 commented 10 months ago

Just updated! Is that back to what you're expecting?