iqbal-lab-org / pling

Plasmid analysis using rearrangement distances
MIT License
28 stars 1 forks source link

End dependency handling via --use-conda flag in snakemake #60

Closed babayagaofficial closed 1 month ago

babayagaofficial commented 4 months ago

So we've been handling dependencies per rule in snakemake, making a new environment each time. This has mostly worked for us, but maybe it's worth reconsidering due to the following things:

I've given a go aggregating all the necessary dependencies in one environment, and running pling from there without the --use-conda flag. It's worked without any issue! So basically should be feasible, and could open up the possibility of bringing back pip installation (important since we've had complaints about installation looking off-putting).

My suggestion would be to handle dependencies for integerisation from alignment directly in pling, and maybe leave the dependencies for annotation as optional, and to be installed manually by the user if they want to run it (dissuading anybody from using annotation appraoch unless they really, really want to). As an initial thing we could remove the snakemake handling of conda environments and dependencies, and add a configuration file for dependencies that can be installed via conda, eventually hopefully upgrading to something like installation via pip and nothing else.